search

nuxt / http

Universal HTTP Module for Nuxt.js
https://http.nuxtjs.org
MIT License
229 stars 51 forks source link

feat: progress bar #105

Open ricardogobbosouza opened 4 years ago

ricardogobbosouza commented 4 years ago

Resolve #52

codecov-commenter commented 4 years ago

Codecov Report

Merging #105 into dev will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
+ Coverage   90.90%   91.07%   +0.16%     
==========================================
  Files           1        1              
  Lines          55       56       +1     
  Branches       30       31       +1     
==========================================
+ Hits           50       51       +1     
  Misses          5        5
Impacted Files Coverage Δ
lib/module.js 91.07% <100.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc3e78e...e335e7c. Read the comment docs.

pi0 commented 4 years ago

Hi @ricardogobbosouza. Thanks for PR :heart: I added a pending label as there is an active discussion nuxt-communiry/axios-module#247 and the best way we should integrate with progress-bar. We might add a shared utility to nuxt for easier integration.

mbergen commented 2 years ago

Is this still being discussed?

pi0 commented 2 years ago

Hi dear @mbergen. Yes, we are discussing it for Nuxt 3 API to be considered as a built-in API.