search

nuxt / http

Universal HTTP Module for Nuxt.js
https://http.nuxtjs.org
MIT License
229 stars 51 forks source link

fix: transpile ky #61

Closed atinux closed 5 years ago

atinux commented 5 years ago

Fixes https://github.com/nuxt/nuxt.js/issues/5065#issuecomment-514360155

If you have an idea for testing @pi0 :)

pi0 commented 5 years ago

@Atinux for testing, we may first wait for next edge release. Then probably ensuring that the module adds a function to transpile patterns and then validate that function behavior.

codecov-io commented 5 years ago

Codecov Report

Merging #61 into dev will increase coverage by 0.5%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev      #61     +/-   ##
=========================================
+ Coverage   96.55%   97.05%   +0.5%     
=========================================
  Files           1        1             
  Lines          29       34      +5     
  Branches       13       16      +3     
=========================================
+ Hits           28       33      +5     
  Misses          1        1
Impacted Files Coverage Δ
lib/module.js 97.05% <100%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26fe197...bd41f83. Read the comment docs.

husayt commented 4 years ago

@pi0 @Atinux this is affecting Edge as well which is considered "modern". So best is to transpile for modern browsers too So instead of 

 this.options.build.transpile.push(({ isLegacy }) => isLegacy && 'ky')

just have

this.options.build.transpile.push('ky')
pi0 commented 4 years ago

@husayt would you please make a PR?