fix(types): fix argument of onError

nuxt / http

Universal HTTP Module for Nuxt.js

https://http.nuxtjs.org

MIT License

229 stars 51 forks source link

fix(types): fix argument of onError #67

Closed edimitchel closed 5 years ago

edimitchel commented 5 years ago

On Nuxt TypeScript project using http module, we have a type error from tslint

 ERROR  ERROR in /.../node_modules/@nuxt/http/types/index.d.ts(141,18):
141:18 Parameter has a name but no type. Did you mean 'arg0: HTTPError'?
    139 |    * This hook enables you to globally handle request errors.
    140 |    */
  > 141 |   onError(hook: (HTTPError) => void): void
        |                  ^
    142 | }
    143 | 
    144 | declare module '@nuxt/vue-app' {

This fix handle simply this typing issue.

pi0 commented 5 years ago

Thanks!

edimitchel commented 5 years ago

@pi0 When is scheduled a release for getting this small fix ?

pi0 commented 5 years ago

Sorry for being late. https://github.com/nuxt/http/releases/tag/v0.3.5 released