search

nuxt / icon

The <Icon> component, supporting Iconify, Emojis and custom components.
https://stackblitz.com/edit/nuxt-icon-playground?file=app.vue
MIT License
868 stars 37 forks source link

Terminal errors and browser warnings in 0.6.2 #118

Closed toniengelhardt closed 8 months ago

toniengelhardt commented 8 months ago

Getting terminal errors and browser console warnings when upgrading from 0.6.1 to 0.6.2 for icons with names ph:table and ph:code:

Screenshot 2023-11-06 at 15 54 56

Screenshot 2023-11-06 at 15 53 50
Atinux commented 8 months ago

Should be fixed in v0.6.3 :)

toniengelhardt commented 8 months ago

Thanks, that was fast 🙏🏽 🙏🏽 🙏🏽

toniengelhardt commented 8 months ago

Hey @Atinux, it looks like the problem is actually still there in v0.6.3:

Screenshot 2023-11-06 at 19 14 08

Also, aliases like 'brand': 'IconBrand' with a global component named IconBrand.vue are now not working anymore.

Atinux commented 8 months ago

Damn I did not expect people to use alias -> components 😅

Fixed in v0.6.5

Also I do not have any warning locally, you can run the playground/ I added a case for it: https://github.com/nuxt-modules/icon/blob/c206f6e7105f92507b8d4f280eea3e0f8467a355/playground/app.vue#L49-L53

toniengelhardt commented 7 months ago

It seems resolved now 🙏🏽

Of course, alias -> components is one of the best features ;)