search

nuxt / icon

The <Icon> component, supporting Iconify, Emojis and custom components.
https://stackblitz.com/edit/nuxt-icon-playground?file=app.vue
MIT License
864 stars 37 forks source link

Deprecate nuxt-icon #181

Open dethdkn opened 2 days ago

dethdkn commented 2 days ago

Hello! Could nuxt-icon (https://www.npmjs.com/package/nuxt-icon) be deprecated so that people don't mistakenly install it instead of @nuxt/icon (https://www.npmjs.com/package/@nuxt/icon)?

antfu commented 2 days ago

We already added a runtime warning in the latest beta of nuxt-icon. For deprecating the npm library, it would be safer to wait for a while longer.

dethdkn commented 2 days ago

@antfu I apologize for not seeing this warning. However, I believe this should be included in the latest version because most people use npm i nuxt-icon or pnpm add nuxt-icon, which installs version 0.6.10 that does not have this warning. I'm mentioning this because I noticed some colleagues mistakenly using the old version of nuxt-icon without realizing it.

I think it would make sense to release a 0.6.11 with the warning on nuxt-icon right? or set the 1.0.0-beta.7 version as the latest

Screenshot from 2024-06-29 22-41-18

antfu commented 2 days ago

Good points, just set 1.0.0-beta.7 as the latest