nuxt / icon

The <Icon> component, supporting Iconify, Emojis and custom components.
https://stackblitz.com/edit/nuxt-icon-playground?file=app.vue
MIT License
883 stars 41 forks source link

feat: add default icon size #2

Closed Atinux closed 1 year ago

Atinux commented 1 year ago

Give the ability to set a default icon size by leveraging the app.config.ts.

Resolves #1

I am not 100% sure about this approach versus using the nuxt.config.ts + public runtime config to give the information back to the component, wdyt @pi0 ?

I do love the DX when having the app.config.ts and see the changes in real-time:

https://user-images.githubusercontent.com/904724/188518312-b37471e2-c369-4b71-a750-a87d91fff056.mp4

Current downside is that I cannot have the autocomplete for the app.config but I guess it's just a typing config that @danielroe can teach me about.

pi0 commented 1 year ago

Using app config seems a really nice idea! Some notes: