search

nuxt / icon

The <Icon> component, supporting Iconify, Emojis and custom components.
https://stackblitz.com/edit/nuxt-icon-playground?file=app.vue
MIT License
883 stars 41 forks source link

Remove default styles and make it headless #24

Closed fayazara closed 1 year ago

fayazara commented 1 year ago

I see that there are a few default styles added in this, which actually make the icons behave differently than it should. https://github.com/nuxt-modules/icon/blob/4ecfd3a4672505799aa040176da9bf737f6b5f9a/src/runtime/Icon.vue#LL56-L61C2

<style scoped>
.icon {
  display: inline-block;
  vertical-align: middle;
}
</style>
Atinux commented 1 year ago

Actually it was to stay consistent when using an emoji for example.

Removing the style will be a breaking change.

What about having an headless option in the app.config.ts?

fayazara commented 1 year ago

Actually it was to stay consistent when using an emoji for example.

Removing the style will be a breaking change.

What about having an headless option in the app.config.ts?

@Atinux - Here's a PR https://github.com/nuxt-modules/icon/pull/32