search

nuxt / icon

The <Icon> component, supporting Iconify, Emojis and custom components.
https://stackblitz.com/edit/nuxt-icon-playground?file=app.vue
MIT License
874 stars 38 forks source link

nuxt-icon breaks type extension of AppConfigInput? #72

Closed jontybrook closed 1 year ago

jontybrook commented 1 year ago

Nuxt version: 3.4.2 nuxt-icon version: 0.4.0 Package manager: pnpm

I'm working on a brand new nuxt project today. I just installed nuxt-icon@0.4.0, and I started getting type errors like this in my app.config.ts:

screenshot_000134-4Vbu3Zpb_25-04-2023_20h31m25s

Removing nuxt-icon from my nuxt modules resolves this. Seems nuxt-icon is breaking dynamic types?

Not sure if this could be related to: https://github.com/nuxt/nuxt/pull/20440 ?

Atinux commented 1 year ago

We are working on it with @danielroe , you can ignore the error for now (it's TS only)

Atinux commented 1 year ago

Could you test with nuxt-edge @jontybrook ?

https://nuxt.com/docs/guide/going-further/edge-channel/#edge-release-channel

jontybrook commented 1 year ago

@Atinux Yes, it works! Edge release 3.4.3-28041948.197de3ec resolves this.

I've confirmed by switching back-and-forth between edge and 3.4.2 and edge works as expected 👍🏼

Huge thanks to you, @danielroe and the whole team for everything you're doing!