nuxt / image

Plug-and-play image optimization for Nuxt applications.
https://image.nuxt.com
MIT License
1.33k stars 271 forks source link

fix: update to latest `@nuxt/module-builder` #1439

Closed danielroe closed 1 month ago

danielroe commented 1 month ago

๐Ÿ”— Linked issue

โ“ Type of change

๐Ÿ“š Description

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: https://github.com/nuxt/nuxt/pull/28480, https://github.com/nuxt/nuxt/pull/28593 See also https://github.com/nuxt/nuxt/issues/28672.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: afd7163
Status: โœ…  Deploy successful!
Preview URL: https://3bac3a5a.nuxt-image.pages.dev
Branch Preview URL: https://update-module-builder.nuxt-image.pages.dev

View logs

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.26%. Comparing base (052f9a9) to head (afd7163).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1439 +/- ## ======================================= Coverage 62.26% 62.26% ======================================= Files 79 79 Lines 3599 3599 Branches 397 397 ======================================= Hits 2241 2241 Misses 1328 1328 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.