search

nuxt / module-builder

Complete solution to build and ship Nuxt modules.
MIT License
211 stars 22 forks source link

fix: load non relative tsconfig #270

Closed FRSgit closed 1 month ago

FRSgit commented 1 month ago

fixes #267 (at least in some cases)

Currently, the loadTSCompilerOptions method does not handle correctly tsconfig.json "extends" field when it contains reference to an npm package.

Examples of such "extends": "extends": "@something/my-config/tsconfig.json" "extends": "@something/my-config/base.json" "extends": "@something/my-config"

With this change the script handles those cases correctly and (at least for me) fixes issue #267

FRSgit commented 1 month ago

Another solution would be to use tsconfck for tsconfig resolution - it resolves extends automatically and without issues.

danielroe commented 1 month ago

Let's use tsconfck 🙏

JiuRanYa commented 1 month ago

Is there anyone following up this?

Same issue here #267

FRSgit commented 1 month ago

I'll update the PR with new implementation today

danielroe commented 1 month ago

Oops, just implemented. Apologies!

FRSgit commented 1 month ago

Not a problem, it wasn't that easy for me to squeeze that one today - I guess I'll do the maintenance somewhere else 😄 Thanks!

JiuRanYa commented 1 month ago

Oops, just implemented. Apologies!

Not matter, Thanks for your great work!