nuxt / modules

Discover the Nuxt modules to add any CMS, Database, UI, Auth and integrations into your Vue application.
https://nuxt.com/modules
MIT License
901 stars 232 forks source link

add more details to download count on full details view #510

Open BracketJohn opened 1 year ago

BracketJohn commented 1 year ago

When checking out the modules page today, I saw that the download count for nuxt-session is off. It is correct on the modules details page

On the repo: https://github.com/sidebase/nuxt-session image

On the modules page: https://nuxt.com/modules image

On the modules details page: https://nuxt.com/modules/session image

In addition the maintainer-count seems to be broken (5 on overview, 1 on details page of nuxt.com/modules).

So in summary:

danielroe commented 1 year ago

We show the monthly download count, not downloads across all time.

image.png

The maintainer count is coming from the data in this repository - so you should feel free to update it.

https://github.com/nuxt/modules/blob/3d6be08bffe66714c2a8fec873c3b60e1eb072b8/lib/modules.ts#L101-L114

BracketJohn commented 1 year ago

I see, thanks - maybe it would be worth it to update the text to / month?

Other than that my question has been answered and if we don't want to adapt it to say / month the issue can be closed, thanks 🙌

danielroe commented 1 year ago

I think it might nice to be something like x installs this month in the 'fuller' detail page version, keeping the minimal approach on the card. wdyt?

BracketJohn commented 1 year ago

Yes, that would be great + maybe we can add a tooltip to the card-stats on hover, to also give that context there?