Closed krisantuswanandi closed 1 year ago
Current IMDb url is imdb.com/movie/:id for all IMDb links, when it should be imdb.com/title/:id for media and imdb.com/name/:id for person.
imdb.com/movie/:id
imdb.com/title/:id
media
imdb.com/name/:id
person
I noticed that they use prefix tt for media and nm for person so I use that to differentiate between the two for the current solution.
tt
nm
Maybe a better approach would be to add a new imdbType prop to ExternalLinks component, but I'll let you guys decide.
imdbType
ExternalLinks
Current IMDb url is
imdb.com/movie/:idfor all IMDb links, when it should beimdb.com/title/:idformediaandimdb.com/name/:idforperson.I noticed that they use prefix
ttformediaandnmforpersonso I use that to differentiate between the two for the current solution.Maybe a better approach would be to add a new
imdbTypeprop toExternalLinkscomponent, but I'll let you guys decide.