nuxt / nuxt.com

The Nuxt website, made with Nuxt.
https://nuxt.com
MIT License
299 stars 156 forks source link

fix(blog): refactor OG Image URL #1626

Closed shinGangan closed 3 months ago

shinGangan commented 3 months ago

๐Ÿ”— Linked issue

closed #1625 .

โ“ Type of change

๐Ÿ“š Description

When I checked the cause, it seemed that the definition method of MDC was different.

The setting method of OG Image URL has changed from V3.

shinGangan commented 3 months ago

HI @benjamincanac , please review when you have a time ๐Ÿ™ THis PR has low review priority.

benjamincanac commented 3 months ago

@shinGangan It's still broken for me in the preview: https://nuxt-website-o5aumb001-nuxt-js.vercel.app/blog/new-website

shinGangan commented 3 months ago

If you look at the target image path, it looks like a path that does not exist. /docs/getting-started/installation/__og_image__/og.png

I checked the commit where the fixed part was added, but it seems that the image has not been added at this commit.

shinGangan commented 3 months ago

Add an image in this PR.

Flosciante commented 3 months ago

hi @shinGangan, thx for contribution, i deployed and it seems it's still broken on the preview https://nuxt-website-i2o3lknwi-nuxt-js.vercel.app/blog/new-website#open-graph-images

shinGangan commented 3 months ago

It seems that my local is going smoothly. It seems okay if there is no problem in the preview(vercel env).

image

Flosciante commented 3 months ago

Nice work @shinGangan thx for the fix

shinGangan commented 3 months ago

@Flosciante , thnaks for merged ๐Ÿ™