search

nuxt / rfcs

RFCs for changes to Nuxt.js
99 stars 2 forks source link

Moving serverMiddleware in the dist folder #5

Closed manniL closed 6 years ago

manniL commented 6 years ago

Hey 👋

Would it be clever to move the used serverMiddleware in the server dist folder as well? (If not we should at least note that they have to be copied as well for deployment)

Pros:

Cons:

related: https://github.com/nuxt/nuxt.js/issues/3948

atinux commented 6 years ago

I do believe it's a bad practice and bring too much complexity of handling edge cases...

garrensweet commented 5 years ago

@manniL I see that this has been denied. I've just spent 14 hours trying to figure out why the serverMiddleware is not executing in production. Could you please make a note in the documentation about this? Seems like it's 1 line and would take a few seconds....

manniL commented 5 years ago

@garrensweet That would be a perfect opportunity for a PR, right? :thinking: The documentation is editable for everyone :relaxed: ( https://github.com/nuxt/docs/blob/master/en/api/configuration-servermiddleware.md )

garrensweet commented 5 years ago

@manniL I believe I've already beat you to that ;)