nuxt / scripts

Third-Party Scripts Meets Nuxt Developer Experience.
https://scripts.nuxt.com
MIT License
326 stars 45 forks source link

Public Release Tasks #30

Closed harlan-zw closed 6 months ago

harlan-zw commented 6 months ago

These are several items that should be completed for the public release of the module. Any contributions are more than welcome.

Tasks for the public announcement: https://github.com/nuxt/scripts/issues/47

Nuxt

Benchamarks

Documentation

Content

(some content exists on all these pages it just needs polishing)

Getting started

Guides

API

Registry

(see below)

Read Me

Home Page

Nuxt Scripts

Tests

Registry Scripts

The initial implementation for all of these scripts is complete. No new scripts should be added at this stage.

The below require proper documentation and sanity checks on implementation. There is some tree-shaking improvements to be made, see Cloudflare Web Analytics example as it's complete.

We also need to properly document which scripts can be bundled.

Analytics

Content

Marketing

Payments

Tracking

Util

oritwoen commented 6 months ago

From my own observation, it makes sense to add e2e tests for Registry Scripts to the list.

Especially when it comes to analytics, they like to "go crazy". I tried to run Google Analytics and use events but it didn't work at all, hence my suggestion to add tests to the registry as well.

Maybe I was doing something wrong in general (I was using the documentation). Anyway, this is a suggestion and if I still have a problem with it after updating the packages, I will make an issue and reproduce it.

harlan-zw commented 6 months ago

Thank you for the feedback @oritwoen. Unfortunately to do an e2e test with the registry scripts is not fully possible for all scripts, we can support it for registry scripts that expose an API to check the data we send it.

I've setup a Google Analytics Reproduction and it seems to be working correctly.

If you can provide the code you had an issue with or a reproduction it would help.

Also please make a new issue, I'm going to close this one :pray: