feat(tpc): build-time third-party-capital composables

nuxt / scripts

Plug-and-play script optimization for Nuxt applications. (Public Preview)

https://scripts.nuxt.com

MIT License

126 stars 8 forks source link

feat(tpc): build-time third-party-capital composables #81

Closed huang-julien closed 2 weeks ago

huang-julien commented 3 weeks ago

This PR re-introduce TPC as dependency and not type provider. TPC will be used to generate all composables (and components if possible).

Composables and components will be generated at USER build-time and not at @nuxt/scripts.

steps:

[x] review from Aurora team for the implementation
[x] clean it
[x] move TPC to peer-deps

optionnal:

[ ] refactor with magic-ast
[ ] do it for embed components

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
scripts-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 11:23am
scripts-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 11:23am

flashdesignory commented 2 weeks ago

would love a follow up with your comment: "We can also add a version check from npm later." That'll be great to show a message to the user, if they're using an outdated version of tpc

huang-julien commented 2 weeks ago

I think this is good for a first implementation. I'll probably open another PR for internal DX to ease the developement with TPC.

harlan-zw commented 2 weeks ago

I'm still not convinced TPC in its current format will be worth maintaining with Nuxt Scripts in the long term but I'm happy to move this forward for the time being once comments are addressed.

Either way this is a nice solution to avoiding the runtime of TPC, great work @huang-julien :clap: