nuxt / typescript

TypeScript Support for Nuxt 2
https://typescript.nuxtjs.org
MIT License
571 stars 124 forks source link

fix: extend typescript peer dependency range to include 5.x #587

Closed rchl closed 1 year ago

rchl commented 1 year ago

After quick look there doesn't seem to be any apparent issues with TypeScript 5 so allow it in the peer dependency range.

Given that TypeScript doesn't really follow semantic versioning rules, it can break at any point but I still think that this is better approach then having to update this module on each TypeScript release. If new TS version breaks this module then we can restrict or fix it then.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b5f581) 100.00% compared to head (ec08d93) 100.00%.

:exclamation: Current head ec08d93 differs from pull request most recent head 8fa3548. Consider uploading reports for the commit 8fa3548 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #587 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 36 36 Branches 9 9 ========================================= Hits 36 36 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nuxt). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nuxt)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rchl commented 1 year ago

@danielroe when you have spare time I think it would be good to release a new version now