search

nuxtlabs / nuxt-component-meta

Gather Nuxt components metadata on build time and make them available on production.
69 stars 6 forks source link

fix: try to only parse meta once during ssr build #54

Closed stafyniaksacha closed 1 year ago

stafyniaksacha commented 1 year ago

Since result is written to disk and only used by nitro, we can avoid computing it twice

stafyniaksacha commented 1 year ago

I don't get why tests are failing on slots after this change. It works when I directly use the library 🤔

@farnabaz I think errors are related https://github.com/nuxtlabs/nuxt-component-meta/pull/52#issuecomment-1458290586

Tahul commented 1 year ago

@stafyniaksacha ; we have same issue on #52 ; @johnsoncodehk is looking after it :)

Tahul commented 1 year ago

(waiting for upstream fix / guidelines on how to solve slots problem)

Tahul commented 1 year ago

Issue mentioned above resolved in other PRs, this looks good to me as well! Thanks @stafyniaksacha :)