[Bug]: vueBase snippet doesn't follow script default language setttings

[cooldevdotcodes]

Environment

---

• Operating System: Darwin
• Node Version: v20.17.0
• Nuxt Version: -
• CLI Version: 3.13.1
• Nitro Version: -
• Package Manager: pnpm@9.9.0
• Builder: -
• User Config: -
• Runtime Modules: -

• Build Modules: -

What went wrong?

I set the default language for script tag to JavaScript as below

"nuxtr.vueFiles.script.defaultLanguage": "js"

but vueBase snippet still set language to TypeScript

<script lang="ts" setup>

</script>

<template>
  <div>

  </div>
</template>

How to reproduce it?

• Set the default language for script tag to JavaScript as below

"nuxtr.vueFiles.script.defaultLanguage": "js"

• Use vueBase snippet to generate code

[zhaolinlau]

@cooldevdotcodes May I know if you have installed another Vue 3 snippet extension? Because it works fine for me.

[cooldevdotcodes]

@zhaolinlau I've just checked it again. It works properly but it requires to restart VS Code or reload the VS Code window to take the effect.

[zhaolinlau]

@cooldevdotcodes for me, I don't need to restart lol

[cooldevdotcodes]

Sadly it doesn't work for me :-( Actually it doesn't work with all Nuxtr's settings, not just the script default language setting.

[zhaolinlau]

@cooldevdotcodes hmm... try using my PR one nuxtr-vscode-0.2.16.vsix.zip

[cooldevdotcodes]

@zhaolinlau I've just installed the extension from your ZIP file and it works perfectly.

• When I change the default language settings, it asks me to reload the window. Seems this behavior is new.
• When I change the first tag settings, it applied immediately.

BTW, vueBase snippet is missing in this one. I can only see vueBaseLayout snippet.

[zhaolinlau]

@cooldevdotcodes I think you were using the older version of nuxtr? Because I didn't change the snippet things, I only added a new functionality which is default language for nuxt files

[cooldevdotcodes]

Nope, I installed Nuxtr VSIX from your ZIP file. In your screenshot (https://github.com/nuxtrdev/nuxtr-vscode/issues/156#issuecomment-2346924328) I also can only see vueBaseLayout.

[zhaolinlau]

I mean even I install the original one from vscode market, it also appears the vueBaseLayout only

[zhaolinlau]

Could you try uninstalling my version and reinstall the original one from vscode extension market?

[zhaolinlau]

@cooldevdotcodes the vueBase snippet got removed in 0.2.16 version of nuxtr

[cooldevdotcodes]

@zhaolinlau I tried to install v0.2.16 from VSCode extension market and Nuxtr default language settings doesn't work. Check my video shot https://drive.google.com/file/d/1fCvRCLP__A2SHJLvEBsjfKmwSyfyUtZ6/view?usp=sharing

[zhaolinlau]

@cooldevdotcodes Yes, because the feature is not existed in v0.2.16, #159 this is my pull request

[zhaolinlau]

If the author/maintainer of this repo merge my pull request #159 , then the feature will only be added in next release

[zhaolinlau]

@zhaolinlau I tried to install v0.2.16 from VSCode extension market and Nuxtr default language settings doesn't work. Check my video shot https://drive.google.com/file/d/1fCvRCLP__A2SHJLvEBsjfKmwSyfyUtZ6/view?usp=sharing

That's a vue file, u should change this setting

[adhamfarrag]

Hello @cooldevdotcodes, @zhaolinlau

I feel bad to keep issues open but been having issues to respond sooner @cooldevdotcodes :)

Your original issue is clear, and will make sure next release has the issue fixed.

vueBase wasn't removed from Nuxtr or the PR @zhaolinlau made. There are changes regarding extension API and snippets, and I believe more snippets aren't working as expected.

@cooldevdotcodes As much happy I am to see the PR with a major change, it's always better to check the code and build the extension locally yourself after checking these changes instead of installing the VSIX. Please, use build and package script commands for this.

[zhaolinlau]

@adhamfarrag Because my PR is based on your latest commit, and the vueBase snippet is got removed from your latest commit

[cooldevdotcodes]

@zhaolinlau Is there any reason why you remove vueBase snippet? I see it more popular than vueBaseLayout.

[zhaolinlau]

The code block is gone @adhamfarrag

src/snippets/index.ts

[zhaolinlau]

@zhaolinlau Is there any reason why you remove vueBase snippet? I see it more popular than vueBaseLayout.

I didn't remove it lol, it's got removed by you

[cooldevdotcodes]

LOL, I'm not @adhamfarrag :-D

[zhaolinlau]

LOL, I'm not @adhamfarrag :-D

My bad XD, got removed by @adhamfarrag

[cooldevdotcodes]

@adhamfarrag Is there any reason why you remove vueBase snippet? I see it more popular than vueBaseLayout.

[adhamfarrag]

Hello @cooldevdotcodes, I didn't mean to delete it. :) Reopening the issue as I'll work on both issues.

[adhamfarrag]

Thanks for reporting this issue @cooldevdotcodes❤️ Pushed a fix and will be added to next release. :)