search

nv-legate / cupynumeric

An Aspiring Drop-In Replacement for NumPy at Scale
https://docs.nvidia.com/cupynumeric
Apache License 2.0
623 stars 71 forks source link

logical_and reduction #1123

Closed JosephGuman closed 8 months ago

JosephGuman commented 9 months ago

Adding logical_and.reduce() functionality by using existing reduction code for products and applying to booleans.

copy-pr-bot[bot] commented 9 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

manopapad commented 9 months ago

/ok to test

JosephGuman commented 9 months ago

Hello @manopapad Could you add the new-feature tag to this PR? I don't believe I have permissions to do this.

manopapad commented 9 months ago

/ok to test

manopapad commented 8 months ago

/ok to test

manopapad commented 8 months ago

@JosephGuman is this good for another round of reviews?

JosephGuman commented 8 months ago

Hello, @manopapad I'm a little confused on the build error reported in the current test. It seems like there's some issue with cunumeric.digitize, but all the tests work fine locally. Do you know what might be the problem here?

manopapad commented 8 months ago

/ok to test

manopapad commented 8 months ago

Hello, @manopapad I'm a little confused on the build error reported in the current test. It seems like there's some issue with cunumeric.digitize, but all the tests work fine locally. Do you know what might be the problem here?

This is an issue with the documentation build, that has been fixed in the main branch. I merged from branch-24.03, so the CI should pass now.

manopapad commented 8 months ago

/ok to test