nv-legate / cupynumeric

An Aspiring Drop-In Replacement for NumPy at Scale
https://docs.nvidia.com/cupynumeric
Apache License 2.0
623 stars 71 forks source link

Adding cov() functionality with tests #1129

Closed JosephGuman closed 8 months ago

JosephGuman commented 8 months ago

Fitting numpy's cov() implementation into cunumeric's framework

copy-pr-bot[bot] commented 8 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

manopapad commented 8 months ago

/ok to test

JosephGuman commented 8 months ago

@manopapad Sorry, I had forgotten to merge my branch with branch-24.03 before making the pull request. I made the update and believe it should be ready for a round of testing.

manopapad commented 8 months ago

/ok to test

manopapad commented 8 months ago

Let me know when you're ready to let CI run the tests again. I need to reiterate the magic words "/ok to test" every time ...

JosephGuman commented 8 months ago

@manopapad I think everything should be good now. If there's anything I missed, I'll fix it immediately and will be going to make all the corrections to average() as well.

manopapad commented 8 months ago

/ok to test