nv-legate / legate.core

The Foundation for All Legate Libraries
https://docs.nvidia.com/legate/24.06/
Apache License 2.0
186 stars 61 forks source link

Add cuda-cudart-static to generated conda environments #914

Closed marcinz closed 9 months ago

marcinz commented 9 months ago

Adding this package should resolve the build issues that have cropped up recently.

Issues that came up in the process:

marcinz commented 9 months ago

This would also need to be updated in meta.yaml so that the metadata is tagged on the output conda package

Will do, but, for now, CI does not seem to be picking the jobs up.

Edit: actually, it seems to already be in meta.yaml.

marcinz commented 9 months ago

@manopapad Do we need to run mypy if it runs as a part of pre-commit? Currently, we are running it for every build, but that does not seem to add any value if I am not wrong.

Also, we seem to be getting some error related to multiprocessing in OS X tests. I wonder if you know what the problem is off the top of your head.

manopapad commented 9 months ago

Do we need to run mypy if it runs as a part of pre-commit?

Sorry, I missed this. I don't think it's necessary to run mypy again if it's getting run as part of pre-commit (assuming we have something like pre-commit-ci running pre-commit also on the server side; we can't guarantee that developers will have run it locally before committing).

marcinz commented 9 months ago

Yes, on this repo we have pre-commit.ci.

marcinz commented 9 months ago

Actually, I will just leave mypy jobs as they are for now since we are not getting too much development going on here atm.