nv-legate / legate.core

The Foundation for All Legate Libraries
https://docs.nvidia.com/legate/24.06/
Apache License 2.0
186 stars 61 forks source link

Stop setting LD_LIBRARY_PATH in the launcher #928

Closed manopapad closed 7 months ago

manopapad commented 8 months ago

There is no reason anymore to mess with LD_LIBRARY_PATH and friends. Our binaries and libraries nowadays have RPATH set appropriately, and the python interpreter should be able to locate cython extensions even under editable installation by looking through PYTHONPATH. Our canonical python support works by accident due to https://github.com/StanfordLegion/legion/issues/1443, which is not ideal, but the plan is to get rid of this path soon, so I'm not worried about that.