search

nv-legate / legate.core

The Foundation for All Legate Libraries
https://docs.nvidia.com/legate/24.06/
Apache License 2.0
186 stars 61 forks source link

Remove unnecessary flags in Legion CMake build #932

Closed elliottslaughter closed 7 months ago

elliottslaughter commented 7 months ago

The flag --root here is a workaround for buggy behavior in pip install where pip would ignore the --prefix setting when --global-option was supplied. As it turns out, --global-option is deprecated anyway so we removed in Legion. As a result, this is no longer required; the prefix is already set in the upstream project and the need for --root goes away with the removal of --global-option.

See this Legion MR for details:

https://gitlab.com/StanfordLegion/legion/-/merge_requests/1072

I'm not sure which branch to send this patch to so if I'm set the wrong one, let me know and I'll update it.

copy-pr-bot[bot] commented 7 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

manopapad commented 7 months ago

/ok to test

manopapad commented 7 months ago

/ok to test

manopapad commented 7 months ago

Editable and non-editable installs seem to work still on my local machine. Merging from main branch, to see if that fixes CI...