dagardner-nv commented 5 months ago

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

This would be a subclass of langchain_core.tools.BaseTool that would allow usage of morpheus.llm.services.llm_service.LLMClient's from a LangChain agent.

Describe your ideal solution

Ideally this would receive either an LLMClient instance as a constructor argument, or an LLMService with the keyword args needed to call get_client.

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open feature requests and have found no duplicates for this feature request

aserGarcia commented 3 months ago

Interested in working on this.

mdemoret-nv commented 3 months ago

@aserGarcia Our development team has been working on the LLM services lately and we have a prototype of this feature already created here. Just wanted to let you know before you started working on this issue.

We appreciate your contributions lately. I just merged your PR. Would be happy to discuss other features you might be interested in working on.

aserGarcia commented 3 months ago

Awesome! Glad it's getting implemented. Thanks for the heads up.

I was considering this improvement since it's been open for a while:

1377 (Update SID with credential detection rules)

But I am also open to whatever helps the team there from the sidelines.

nv-morpheus / Morpheus

[FEA]: Create a Langchain Tool for Morpheus LLM Services #1537