[FEA]: Convert all uses of `#pragma GCC visibility push(default)` to use `MORPHEUS_EXPORT`

mdemoret-nv commented 5 months ago

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

We have mixed usage of #pragma GCC visibility push(default) and MORPHEUS_EXPORT which is inconsistent. Since using #pragma GCC is not part of the C++ standard, it would be better to use MORPHEUS_EXPORT to allow other compilers to be used in the future. Using MORPHEUS_EXPORT is more explicit and works more consistently (in my experience).

Describe your ideal solution

The following should be completed to close this issue:

Completion Criteria

[ ] Remove all uses of #pragma GCC visibility push(default) and #pragma GCC visibility pop
[ ] Determine rules for which classes/functions/structs/etc should be exported
[ ] Add these rules to the developer docs
[ ] Using the above rules, add MORPHEUS_EXPORT to the classes/functions/structs/etc which should be exported

Additional context

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open feature requests and have found no duplicates for this feature request

aserGarcia commented 4 months ago

Looking to work on this as a first issue. I take it no test is required for this one as it's not listed in the completion criteria?

aserGarcia commented 4 months ago

~~I have a working solution but I do not have permission to push the branch remote: Permission to nv-morpheus/Morpheus.git denied to aserGarcia.~~ Disregard.

nv-morpheus / Morpheus