nv-morpheus / Morpheus

Morpheus SDK
Apache License 2.0
347 stars 130 forks source link

Fix non-deterministic output of gnn sampler #1677

Closed tzemicheal closed 4 months ago

tzemicheal commented 5 months ago

Description

Fix the issues by updating the sampler during inference to full sampling from subsampling.

Closes #1676

By Submitting this PR I confirm:

tzemicheal commented 5 months ago

The issue is caused due to the non-determinist part introduced by dgl.dataloading.DataLoader when used along neighbor dgl.dataloading.MultiLayerNeighborSampler sampling instead of full sampling. There are two ways to fix this (which both of them fixed the issue)

mdemoret-nv commented 4 months ago

/merge