search

nv-morpheus / Morpheus

Morpheus SDK
Apache License 2.0
347 stars 130 forks source link

The `cache_mode` description in DFP docs is incorrect #1696

Closed ylnhari closed 4 months ago

ylnhari commented 4 months ago

https://github.com/nv-morpheus/Morpheus/blob/26c95e13fe996dfed61f53dabf8f4267f8d84504/examples/digital_fingerprinting/production/morpheus/dfp/modules/dfp_rolling_window.py#L51

This comment seems to confuse the actual use of the config setting.

efajardo-nv commented 4 months ago

Thanks @ylnhari. Yes, that needs to be fixed.

efajardo-nv commented 4 months ago

Use the corrected descriptions in #1634 if cache_mode support is being added to stage implementation of DFP Rolling Window.