Replace `isinstance` check with with `callable` in `LLMService.create` - Githubissues

nv-morpheus / Morpheus

Morpheus SDK

Apache License 2.0

310 stars 119 forks source link

Replace `isinstance` check with with `callable` in `LLMService.create` #1723

Closed dagardner-nv closed 1 month ago

dagardner-nv commented 1 month ago

Description

Allows for classes to be replaced by mocks and factory methods
Improved error message for missing service
Fix broken tests
Add new tests

By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.