search

nv-tlabs / GET3D

Other
4.17k stars 374 forks source link

Paper and Project Page diagram was not consistent. #142

Closed youngstu closed 10 months ago

youngstu commented 11 months ago

Paper and Project Page diagram was not consistent. Which is right?

image image

matbee-eth commented 10 months ago

Logically the bottom image supports a loop and the top image doesnt, so I would /assume/ the bottom is what's happening

Bathsheba commented 10 months ago

The top image is as described in the main body of the paper, but if you look in the Appendix they later thought of another model that they like better, that's the default in the code and it is the bottom image.

SteveJunGao commented 10 months ago

Yes, we found the bottom one (shared tri-planes) worked better after we submitted the paper. To avoid the major change to the main paper, we chose to keep the main paper unchanged, put the better model (bottom one) in the Appendix, and use it in the code (so that people can try a better model)

Note that, our codebase supports both model architectures, you can play with the first one by simply setting --one_3d_generator 0