search

nv-tlabs / GSCNN

Gated-Shape CNN for Semantic Segmentation (ICCV 2019)
https://nv-tlabs.github.io/GSCNN/
Other
915 stars 200 forks source link

Questions about the numerical_gradients_2d function #17

Open lijing1996 opened 4 years ago

lijing1996 commented 4 years ago

Thanks for sharing your work! It seems a bug here:

https://github.com/nv-tlabs/GSCNN/blob/64f84878c6d4aabbf74d7e74fe27f38aa408c7ec/my_functionals/custom_functional.py#L38-L52 The numerical_gradients_2d function call this function that return the input directly and the input is only processed by the triangle filter. I wonder whether it was a bug here.

tovacinni commented 4 years ago

Hi, thanks for your interest in our work!

I believe this is a bug, probably an old debugging artifact that got reinstantiated when we were cleaning our code for release. I'll investigate into this a bit more later when I have a bit more time on my hands. Sorry for the inconvenience. :/

shoutOutYangJie commented 4 years ago

Hi, thanks for your interest in our work!

I believe this is a bug, probably an old debugging artifact that got reinstantiated when we were cleaning our code for release. I'll investigate into this a bit more later when I have a bit more time on my hands. Sorry for the inconvenience. :/

thank you! I look forward to your training code!