nvaccess / mrconfig

'myrepos' configuration files for nvda translations and addons
GNU General Public License v3.0
5 stars 14 forks source link

Update pot build command as per the one in NVDA's repo (update in PR NVDA/#15013) #106

Closed CyrilleB79 closed 1 year ago

CyrilleB79 commented 1 year ago

Issue

Today, the first version of NVDA including https://github.com/nvaccess/nvda/pull/15013 has been merged to SVN. The translatable strings using ngettext appear in the nvda.po as expected. But the strings using npgettext ("%.1f lignes") don't.

Cause

In PR https://github.com/nvaccess/nvda/pull/15013, the command to build the .pot file has been updated to be able to recognize npgettext as a function operating on translatable strings. However, the nvda2svn script in the current repository does not use the .pot generated by NVDA's sconstruct; xgettext is called directly in the current repository instead. Thus the command in the nvda2svn script should match the one in NVDA's sconstruct. The change in NVDA's repository had not been duplicated here.

Solution

Update xgettext's parameters as per what was done in NVDA's repo to be able to detect ngettext as a function operating on translatable strings.

Testing

I have no way to test before merging this PR.

@seanbudd, could you test manually this branch on NVAccess server the result of nvda2svn script or merge this PR and trigger nvda2svn?

seanbudd commented 1 year ago

All test steps appear successful