search

nvaccess / mrconfig

'myrepos' configuration files for nvda translations and addons
GNU General Public License v3.0
5 stars 14 forks source link

Updates for the structure diff scripts: #125

Closed CyrilleB79 closed 2 months ago

CyrilleB79 commented 3 months ago

Various updates for the diff script:

Issues

  1. Change log structure difference should also be checked in prevision of the migration to Crowdin. The script was capable to check the change log but it has not been enabled when it was introduced
  2. In case no difference is found, it may not be clear for the user if the structure has been checked or not. See this discussion for example.
  3. In case the two files being compared have not the same length, only the common part is being compared.

Solutions:

  1. Now also checks the diffs of the change log
  2. Indicate the files being compared in the report as it was done in the old version of t2t comparison.
  3. Use itertools.zip_longest instead of zip when reading the files content

Tests

  1. Not tested
  2. and 3. Manual test locally on my Windows computer.

Known issues

I have not been able to test 1. Please double check when committing on the server. Thanks.

Cc @michaelDCurran