search

nvaccess / mrconfig

'myrepos' configuration files for nvda translations and addons
GNU General Public License v3.0
6 stars 14 forks source link

Register Character Information in translation system #32

Closed CyrilleB79 closed 3 years ago

CyrilleB79 commented 3 years ago

Could you please register Character Information in the translation system? This add-on is already present on the official add-on community website.

GitHub repo URL: https://github.com/CyrilleB79/charInfo

The files to be synchronized are the interface file (.po) as well as the documentation (.md), as for other add-ons.

Note: The translation of localized files specific to this add-on (found in addon/globalPlugins/charinfo/locale/xx) should not be localized via this automatic translation framework. Instead, localization of these files should be done directly via PR's in the charInfo add-on's repo or contacting the add-on author (me).

CyrilleB79 commented 3 years ago

Additional note: For now, I have manual French translations in addon/doc and addon/locale. Let me know if I should remove the translated files from these folders. Thanks.

feerrenrut commented 3 years ago

I can't give advice on these questions at this stage. Please follow the same procedure as other addon's.

CyrilleB79 commented 3 years ago

@nvdaes any thought? You were used to register add-ons in the past. I guess I should remove the existing translations in stable branch; that's not a problem for me provided the various steps of the workflow do not require too much time to be validated. Could you confirm it so that I can proceed? Thanks.

nvdaes commented 3 years ago

Hi Cyrille, I'm not sure if not removing the existing translations will or not cause an issue. But maybe. I recommend you to remove them from stable branch. Then, to follow instructions, you need to request the registration in the translation system via the add-ons mailing list, so that people of nvdaaddons organization (managed by the community) can fork your repo. Then I (or someone of the nvdaaddons organization) will fork your repo so that NV Access can proceed with needed changes in the server.

2021-06-21 13:52 GMT+02:00, Cyrille Bougot @.***>:

@nvdaes any thought? You were used to register add-ons in the past. I guess I should remove the existing translations in stable branch; that's not a problem for me provided the various steps of the workflow do not require too much time to be validated. Could you confirm it so that I can proceed? Thanks.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/mrconfig/issues/32#issuecomment-864971160

CyrilleB79 commented 3 years ago

Indeed, I had already asked the inclusion of this add-on in the translation framework on the add-on mailing list. And here was your answer 😕:

About how to register new add-ons in the system, Reef requested me to open an issue (I requested to register PC Keyboard Braille Input add-on), and Reef's request was also intended to study the details of the system (originally created by Mesar). Reef's request can be found in issue 3 of the mr config repo, and the issue created by me is at

https://github.com/nvaccess/mrconfig/issues/30

The full thread can be read here.

Anyway, I have removed the existing French translations. Please let me know here or in the corresponding thread of the mailing list if something is still required on my side for the creation of the fork in the community repo. Thanks.

nvdaes commented 3 years ago

OK, I've asked you to request this on the list since the instructions have been updated today. But, since you requested it before, I'll fork your repo today :)

2021-06-21 15:41 GMT+02:00, Cyrille Bougot @.***>:

Indeed, I had already asked the inclusion of this add-on in the translation framework on the add-on mailing list. And here was your answer 😕:

About how to register new add-ons in the system, Reef requested me to

open an issue (I requested to register PC Keyboard Braille Input

add-on), and Reef's request was also intended to study the details of

the system (originally created by Mesar). Reef's request can be found

in issue 3 of the mr config repo, and the issue created by me is at

https://github.com/nvaccess/mrconfig/issues/30

The full thread can be read here.

Anyway, I have removed the existing French translations. Please let me know here or in the corresponding thread of the mailing list if something is still required on my side for the creation of the fork in the community repo.

Thanks.

--

You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub:

https://github.com/nvaccess/mrconfig/issues/32#issuecomment-865042713

nvdaes commented 3 years ago

@CyrilleB79 , I've created the needed fork of the repo on nvdaaddons organization and has sent you an invitation as a collaborator with write access in the fork, so you can manage the stable branch ensuring that the messages to be translated are updated there. @feerrenrut or NV Access staff, you can activate the translation in the server. Thanks

CyrilleB79 commented 3 years ago

Thanks @nvdaes, I have accepted this invitation. The stable branch was already up-to-date (with removed French translations) when you forked the repo in nvdaaddons. So I confirm that nvdaaddons / charInfo can be included now in the translation framework.

nvdaes commented 3 years ago

Is this repo related to text files not affected by gettext? I think it isn't. This maybe reported to translators, imo.

CyrilleB79 commented 3 years ago

@nvdaes can you clarify? I do not understand your last comment.

nvdaes commented 3 years ago

I think this repo is intended to generate and produce po files, so, if text files that shouldn't be localized are not related to gettext, they won't produce po files and then I think you should inform translators on the translations mailing list, for example, not here.

CyrilleB79 commented 3 years ago

Yes, I will inform translators on the mailing list when this PR is merged.

The note in this PR was not intended for translators but for NVAccess people to say: This add-on contains language folders that are not located at the standard place. But that's not a proplem for translation framework since these folders do not contain any source file for .po generation.

I hope things are clarified now.

nvdaes commented 3 years ago

Ok Cyrille. Thanks

CyrilleB79 commented 3 years ago

@feerrenrut, this add-on and other ones are waiting for their inclusion in the translation framework. Now that the various existing issues have been fixed with Windows Magnifier add-on (thanks again), do you plan to integrate soon Character Information as well as other add-ons for which inclusion was required? Thanks.

feerrenrut commented 3 years ago

I have set this up, but there is an error, @nvdaes nvaccessAuto needs permission to push to https://github.com/nvdaaddons/charInfo

nvdaes commented 3 years ago

Hello: Now I've granted write access to NvaccessAuto.

2021-07-21 12:25 GMT+02:00, Reef Turner @.***>:

I have set this up, but there is an error, @nvdaes nvaccessAuto needs permission to push to https://github.com/nvdaaddons/charInfo

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/mrconfig/issues/32#issuecomment-884077931

CyrilleB79 commented 3 years ago

Thanks. More generally, shouldn't NvaccessAuto have the right for all repos in nvdaaddons account? Unless it is already the case of course. This would prevent @nvdaes to grant new rights for each new fork.

nvdaes commented 3 years ago

For me it would be a good idea. For any reason NvaccessAuto cannot write in new forked repos, but for now the only option that I find is to make it an owner @Josephsl And I don't know if it's a good idea dealing with an automation system, in case of some unintentional failure

2021-07-21 16:33 GMT+02:00, Cyrille Bougot @.***>:

Thanks. More generally, shouldn't NvaccessAuto have the right for all repos in nvdaaddons account? Unless it is already the case of course. This would prevent @nvdaes to grant new rights for each new fork.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/mrconfig/issues/32#issuecomment-884238682

feerrenrut commented 3 years ago

Just a reminder, even though it looks like we are putting work to optimize the mrconfig based translation system, we plan to move to anew more distributed approach. @CyrilleB79 you may be interested to read: https://github.com/nvaccess/translationSystem

feerrenrut commented 3 years ago

Thanks for fixing the permissions @nvdaes. This addon is now registered.