Include easyTableNavigator to translation

nvaccess / mrconfig

'myrepos' configuration files for nvda translations and addons

GNU General Public License v3.0

6 stars 14 forks source link

Include easyTableNavigator to translation #44

Closed CoBC closed 3 years ago

CyrilleB79 commented 3 years ago

This does not pretend to be an exhaustive review. However I have 2 remarks:

The following file should be created: available.d/10_easyTableNavigator. For now it is missing.
In nvdaaddons/easyTableNavigator, the stable branch should point to the last stable version, i.e. 2.2.1. More precisely master has to be merged in the stable branch.

CoBC commented 3 years ago

As I can see, 10_easyTableNavigator isn't missing: https://github.com/nvaccess/mrconfig/blob/master/available.d/10_easyTableNavigator

CyrilleB79 commented 3 years ago

As I can see, 10_easyTableNavigator isn't missing: https://github.com/nvaccess/mrconfig/blob/master/available.d/10_easyTableNavigator

Sorry, my bad. Only the other point is relevant.

CoBC commented 3 years ago

I've made a commit on my repo to make scons pot mergePot working

CyrilleB79 commented 3 years ago

@Oreonan, as already written before, you need to merge the master branch into the stable branch and push the stable branch in the nvdaaddons repo. Else, you won't get any translatable string.

CoBC commented 3 years ago

I'm waiting an invitation to nvdaaddons to do this. I requested this this morning to Noelia.

CoBC commented 3 years ago

It's now did.

feerrenrut commented 3 years ago

Thanks for making the updates here. Though having now been through this process with a number of other add-on's it is probably easier for me to do this manually. I'm going to close this PR and replace it with a new issue with the Addon registration template: https://github.com/nvaccess/mrconfig/issues/49