[Register add-on in translation system]: access8Math

nvaccess / mrconfig

'myrepos' configuration files for nvda translations and addons

GNU General Public License v3.0

6 stars 14 forks source link

[Register add-on in translation system]: access8Math #58

Closed nvdaes closed 3 years ago

nvdaes commented 3 years ago

Add-on name

Access8Math

Add-on maintainer

@tsengwoody

Stable branch

[X] Stable branch exists in add-on repo

nvdaes commented 3 years ago

@tsengwoody, GitHub Actions cannot build the .pot file and scons is terminated. Check the actions link to see tha workflow failure corresponding to this issue. Maybe you have a non ascii character? Unless @feerrenrut says a different thing, you should fix this before this add-on can be included in the translations system. Also, usually add-on names start in lowercase, but I think that this will not affect the result of the registration. Thanks

CyrilleB79 commented 3 years ago

Yes, A8M_PM.py has a BOM at the beginning. The file should be formatted in UTF8 without BOM (due to gettext limitation if I remember well).

tsengwoody commented 3 years ago

I update my repository to fixed A8M_PM.py bom character and use gettext to translate about message. Do I need do any another step?

nvdaes commented 3 years ago

Lets close and reopen to see if GitHub Actions can build the add-on now.

nvdaes commented 3 years ago

This is not working for now. I suggest you:

See section encoding of the contributing to NVDA document
- You may want to use a GitHub workflow created by @mhameed, first creator of the current translation system used by NVDA and add-ons, contributor to add-ons and to the add-on template among other things. This GitHub workflow created by him checks if Python files contain BOM characters. He helped me to practice GitHub Actions too. You may find the mentioned workflow (.yaml file) in add-ons like clipContentsDesigner

CyrilleB79 commented 3 years ago

@tsengwoody, you have updated the stable branch in your repo, but you need to push it to the nvdaaddons fork of your repo (https://github.com/nvdaaddons/Access8Math.git). The translation framework looks and interact with this fork, not your personal repo so you need to synchronize them.

tsengwoody commented 3 years ago

I seem to have`t write permission git push got error fatal: unable to access 'https://github.com/nvdaaddons/Access8Math/': The requested URL returned error: 403 or how to synchronize?

nvdaes commented 3 years ago

Thanks Cyrille and Woody. @tsengwoody, I've just invited you to the repo in nvdaaddons organization. Please accept the invitation and push to stable branch.

2021-09-08 9:19 GMT+02:00, Tseng Woody @.***>:

I seem to have`t write permission git push got error fatal: unable to access 'https://github.com/nvdaaddons/Access8Math/': The requested URL returned error: 403 or how to synchronize?

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/mrconfig/issues/58#issuecomment-914985252

tsengwoody commented 3 years ago

I updated nvdaaddons repo please try again

github-actions[bot] commented 3 years ago

The add-on and pot files were built from stable branch

nvdaes commented 3 years ago

Thanks. All is right now, ready to be included in the translations system when @feerrenrut can do it.

feerrenrut commented 3 years ago

This should now be available for translation.