search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.12k stars 638 forks source link

Speak More button and context menu in Clipboard History Window #10597

Open MarcoZehe opened 4 years ago

MarcoZehe commented 4 years ago

Steps to reproduce:

  1. Enable Clipboard History in Settings.
  2. Copy a few items to the clipboard.
  3. In NotePad or any other text field, press WindowsKey+V.
  4. Select an item from the list.
  5. Press Tab.
    • Expected: NVDA should say "More button".
    • Actual: NVDA remains silent.
  6. Press SpaceBar.
    • Expected: NVDA should announce the appearance of the context menu, and announce the first item.
    • Actual: No announcement.

Actual behavior:

See after steps 5 and 6 above.

Expected behavior:

See after steps 5 and 6 above.

System configuration

NVDA installed/portable/running from source:

Installed.

NVDA version:

2019.3Beta1

Windows version:

19h2, 20h1.

Name and version of other software in use when reproducing the issue:

Several apps including Firefox and NotePad.

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

2019.2.1, same result.

Does not happen with Narrator. Narrator reads both the button and the popup menu just fine.

CC @josephsl

josephsl commented 4 years ago

Hi, I’ve been trying to look for a way to do that for several months to no avail. I’ll keep looking for a solution. Thanks for reminding me about this.

From: Marco Zehe notifications@github.com Sent: Monday, December 9, 2019 2:52 AM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: [nvaccess/nvda] Speak More button and context menu in Clipboard History Window (#10597)

Steps to reproduce:

  1. Enable Clipboard History in Settings.
  2. Copy a few items to the clipboard.
  3. In NotePad or any other text field, press WindowsKey+V.
  4. Select an item from the list.
  5. Press Tab.
  1. Press SpaceBar.

Actual behavior:

See after steps 5 and 6 above.

Expected behavior:

See after steps 5 and 6 above.

System configuration

NVDA installed/portable/running from source:

Installed.

NVDA version:

2019.3Beta1

Windows version:

19h2, 20h1.

Name and version of other software in use when reproducing the issue:

Several apps including Firefox and NotePad.

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

2019.2.1, same result.

Does not happen with Narrator. Narrator reads both the button and the popup menu just fine.

CC @josephsl https://github.com/josephsl

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/10597?email_source=notifications&email_token=AB4AXEFE64D2OQDGUYKPHLTQXYBLVA5CNFSM4JYFPZB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7AC3WQ , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEBNYQYNM5MGIG75KILQXYBLVANCNFSM4JYFPZBQ .

josephsl commented 4 years ago

Hi,

Turns out these controls do not fire focus change events.

Technical: UIA objects come with "shouldAllowUIAFocusEvent" property, which returns whether the element can declare itself keyboard navigable (has keyboard focus property is used). For some reason, clipboard history context menu and other parts of this part of modern keyboard does not expose this at all, so a hack is needed until Microsoft fixes this (as usual). That is, NVDA won't announce these controls unless focus event property is forcefully set to "True", which I'll do as part of next Windows 10 App Essentials add-on release; side effects include focus getting stuck if clipboard history is invoked from a non-UIA control such as Notepad.

Thanks.

josephsl commented 4 years ago

Hi,

Clarification: rather, "has keyboard focus" is set to "False".

Thanks.

josephsl commented 4 years ago

Hi,

Further testing shows that it could introduce issues when opening clipboard history while focused on IAccessible objects such as Notepad++ - works beautifully for UIA controls, not so much for MSAA ones at the moment. One possible workaround might be to coerce focus event for these controls to live region or name change events, which may allow correct focus event handling once clipboard history is closed.

Thanks.

Ignite25 commented 4 years ago

Hello! This is my first comment using Github so excuse me if something doesn't go right. I have noticed as well you can't get to the more button using NVDA. Which means you can't pin what you copied. I was told a work around for that, try , copying a string of text to clipboard, press Windows key + V to bring up clipboard, if the focus is not on what you just copied arrow to it, then press the letter P to pin to your clipboard, if you want to delete a entry I press the delete button beside the page down button. Since you have pinned to the clipboard now it will still be there when you turn your computer back on again. the more button allows you to pin for anyone who doesn't know.

josephsl commented 4 years ago

Hi, this whole thing is caused by focus change event issue – a few days ago I worked on a possible workaround, but found that it causes regressions with focus change not announced in IAccessible controls such as Notepad++. Thanks.

From: Ignite25 notifications@github.com Sent: Friday, December 20, 2019 12:24 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] Speak More button and context menu in Clipboard History Window (#10597)

Hello! This is my first comment using Github so excuse me if something doesn't go right. I have noticed as well you can't get to the more button using NVDA. Which means you can't pin what you copied. I was told a work around for that, try , copying a string of text to clipboard, press Windows key + V to bring up clipboard, if the focus is not on what you just copied arrow to it, then press the letter P to pin to your clipboard, if you want to delete a entry I press the delete button beside the page down button. Since you have pinned to the clipboard now it will still be there when you turn your computer back on again. the more button allows you to pin for anyone who doesn't know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/10597?email_source=notifications&email_token=AB4AXEHMDWDAPUEU3RMFA5LQZUSUNA5CNFSM4JYFPZB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOCLMQ#issuecomment-568075698 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEFR7OWDPTROKZTRAQDQZUSUNANCNFSM4JYFPZBQ .

frostytoaster commented 4 years ago

Hi, This could be a very useful feature, if it's a Microsoft issue is it worth bringing it up as a feed back issue?

josephsl commented 4 years ago

Hi,

If possible, yes. Note that if implemented from Microsoft, it won't show up until later this year or next year at the earliest, as version 2004 (20H1) is done.

Thanks.

josephsl commented 4 years ago

Hi,

Update: #11445 and treating clipboard history interface elements as focusable should resolve this issue, although it intorduces user experience issues.

Thanks.

Adriani90 commented 2 weeks ago

@josephsl any update now with NVDA 2024.4? Has this been solved long ago via #11447?

josephsl commented 2 weeks ago

Hi,

Yes, this is still the case in NVDA 2024.4. My primary development machine is running Windows 11 so may not be able to work on this now.

Thanks.