nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.08k stars 626 forks source link

In-build dual voice for sapi 5 in NVDA 2019.3 and above #10740

Closed artimei closed 4 years ago

artimei commented 4 years ago

Hello. I think that everyone knows about such a wonderful and unique addition as Dual voice for automatic switching of voices to sapi 5. Unfortunately, the developer has long ceased support for the addon and does not get in touch. since 2019.3 requires Python 3, this addon does not work anymore with new versions of nvda. why not make support for automatic sapi 5 voice switching inside nvda? especially since the source code of the addon is. I am Russian and use the Ivona synthesizer: Tatyana for the Russian text and Sally for English. I tried all available synthesizers that exist and came to the conclusion that not one Russian voice of any synthesizer reads normally English text. they read, but it’s very difficult to understand what exactly. also Tatyana almost perfectly pronounces my native language, which other synthesizers cannot afford. therefore, the lack of this synthesizer in future versions of nvda is a problem for me. I think that not only for me.

josephsl commented 4 years ago

Hi,

I think we are talking about two different things here:

  1. Dual Voice add-on: at this time, this add-on is listed as incompatible. The best option now is contacting the author one more time.
  2. Ivona voices: I advise contacting the synthesizer developer about this one.

I'm in favor of closing this issue as "wontfix" unless other people say it should be investigated.

Thanks.

Adriani90 commented 4 years ago

However, if this is especially an issue with Sapi 5 voices and auto switching language, at least NVDA should take care of the language switching feature at driver level and not at synthesizer level. However, I do not have experience that much with SAPI 5 voices and cannot really assess if there are related bugs at driver level. cc: @michaelDCurran

artimei commented 4 years ago

The Ivona synthesizer works like sapi 5 in nvda, like any other synthesizer, but only as one voice. without the ability to automatically switch voices. This function is performed by a two-voice addon. The addon developer does not contact. if you connect a synthesizer in the form of an add-on, such as a vocalizer, then automatic switching will work. but the Ivona synthesizer does not have an addon.

josephsl commented 4 years ago

Hi, in this case, the best option going forward would be letting the NVDA community take care of Dual Voice add-on. I’ll go ahead and ask on the appropriate mailing list. Thanks.

From: artimei notifications@github.com Sent: Thursday, January 30, 2020 2:54 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com Subject: Re: [nvaccess/nvda] In-build dual voice for sapi 5 in NVDA 2019.3 and above (#10740)

The Ivona synthesizer works like sapi 5 in nvda, like any other synthesizer, but only as one voice. without the ability to automatically switch voices. This function is performed by a two-voice addon. The addon developer does not contact. if you connect a synthesizer in the form of an add-on, such as a vocalizer, then automatic switching will work. but the Ivona synthesizer does not have an addon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/10740?email_source=notifications&email_token=AB4AXECQRZHIXD62CQ3OHGLRANK7NA5CNFSM4KN3YJMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKM3UPY#issuecomment-580500031 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEGLLXAIX4OJWLBHEXDRANK7NANCNFSM4KN3YJMA .

Adriani90 commented 4 years ago

Ok then it seems the problem is not at driver level but on synth level. Note that there are more than one Ivona voice vendors on the market. Did you try to contact all of them? http://www.ttsforaccessibility.com/contact_tts/ https://www.readspeaker.com/support/ https://harposoftware.com/en/contact

And by the way, the company belongs to Amazon since 2014. So you might contact the amazon development center to address your issues with the voices.

Since Ivona is a paid license product, it will not be implemented in NVDA.

Closing as invalid.

Mahmood-Taghavi commented 4 years ago

Hi everyone, I am the developer of dual voice add-on. The problem is not upgrading to Python 3. It seems the NVDA synthesizer code is re-designed. Hence, I could not add sliders for control speed and other parameters of the second voice in the NVDA voice setting dialog. I tried to design an attachable dialog to NVDA using WX which be similar to the vocalizer synthesizer setting dialog to support the setting of second voice such as voice name, speed, pitch, and volume. Unfortunately, another problem seems to exist in the NVDA re-designed Sapi 5 code (or other dependent codes) which not let using SAPI 5 XML to change voice, pitch, volume, and rate (actually it lead to errors). Hence, I could not use Sapi 5 XML and cannot make dual voice add-on compatible with the upcoming NVDA until the NVDA fix that recent serious problem with SAPI 5 XML. Moreover, I prefer the voice changing support internally be implemented in NVDA (if possible) because the dual voice could switch only between SAPI 5 voice while some users wanted to use for example two voices from different bases such as Microsoft core and SAPI5 (or eSpeak) which is not easy to implement in an addon. Furthermore, I wish NVDA provides some statistics about statistics of add-on active users for developers and perhaps with complementary information such as their setting for NVDA, also if users could request features and vote for it, it would show the quantity of the importance of each request features to the NVDA community. Best Mahmood Taghavi https://github.com/Mahmood-Taghavi/dual_voice

Adriani90 commented 4 years ago

Thanks very much @Mahmood-Taghavi for your contribution. I am reopening this discussion. cc: @michaelDCurran, @codeofdusk

codeofdusk commented 4 years ago

Looks like a duplicate of #279 to me. Should be much easier to implement now thanks to speech refactor.

Adriani90 commented 4 years ago

Thanks @codeofdusk, good pick. I also think this is a duplicate. @Mahmood-Taghavi please follow the discussion in #279.

Mahmood-Taghavi commented 4 years ago

Hi dear users and developers. I am pleased to announce a new release of the Dual Voice addon for NVDA which is now compatible with the NVDA 2019.3.1. Dual voice is an addon that made possible use of two different voices (currently both voices must support SAPI5 standard) for reading two languages one with Latin script and another with non-Latin writing script. For example, a user can select a voice for reading English as a language with the Latin writing script and select a voice for reading Persian (my language) as a language with the non-Latin writing script. Languages with the Latin writing script are English, Czech, Croatian, Finnish, French, German, Italian, Polish, Portuguese, Slovenian, Spanish, and Turkish. Languages with the non-Latin script are Persian, Arabic, Belarusian, Bulgarian, Chinese, Greek, Hebrew, Japanese, Korean, Russian, and Ukrainian. You can find more information on the homepage of the Dual Voice for NVDA. You can download the latest version of the Dual Voice for NVDA Note: You can now use a custom dialog box entitled "Dual voice" in the NVDA menu to select the secondary voice and setting of the Dual voice. P.S. Could someone send this news to the NVDA addon user group, because my registration to that emailing list is not confirmed yet.

josephsl commented 4 years ago

Hi, I’ll take care of it and will close this issue. Thanks.

From: Mahmood Taghavi notifications@github.com Sent: Wednesday, February 26, 2020 2:09 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Comment comment@noreply.github.com Subject: Re: [nvaccess/nvda] In-build dual voice for sapi 5 in NVDA 2019.3 and above (#10740)

Hi dear users and developers. I am pleased to announce a new release of the Dual Voice addon for NVDA which is now compatible with the NVDA 2019.3.1. Dual voice is an addon that made possible use of two different voices (currently both voices must support SAPI5 standard) for reading two languages one with Latin script and another with non-Latin writing script. For example, a user can select a voice for reading English as a language with the Latin writing script and select a voice for reading Persian (my language) as a language with the non-Latin writing script. Languages with the Latin writing script are English, Czech, Croatian, Finnish, French, German, Italian, Polish, Portuguese, Slovenian, Spanish, and Turkish. Languages with the non-Latin script are Persian, Arabic, Belarusian, Bulgarian, Chinese, Greek, Hebrew, Japanese, Korean, Russian, and Ukrainian. You can find more information on the homepage of the Dual Voice for NVDA https://mahmood-taghavi.github.io/dual_voice/ . You can download the latest version of the Dual Voice for NVDA https://github.com/Mahmood-Taghavi/dual_voice/releases/download/v4.1/dual_voice-4.1.nvda-addon Note: You can now use a custom dialog box entitled "Dual voice" in the NVDA menu to select the secondary voice and setting of the Dual voice. P.S. Could someone send this news to the NVDA addon user group, because my registration to that emailing list is not confirmed yet.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/10740?email_source=notifications&email_token=AB4AXEC2HJQBWLTD2WZKYKTRE3R55A5CNFSM4KN3YJMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCCR4Y#issuecomment-591669491 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEGVCTY2UYFOI6NWIV3RE3R55ANCNFSM4KN3YJMA .