search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.08k stars 626 forks source link

NVDA+Up fails to read or spell many controls and lines in Google Chrome #11285

Open amirsol81 opened 4 years ago

amirsol81 commented 4 years ago

Insert+Up (NVDA+Up) is used in NVDA to report the current line under the application cursor. Pressing it twice will spell the current line. Pressing three times will spell the line using character descriptions. However, pressing it on many controls in Google Chrome 127 forces NVDA to remain silent instead of reporting the current line or spelling the current line. This happens in various places like the menu (ALT+F), the list of bookmarks (ALT+F+B), etc. Note: the issue was originally reported with Chrome 83, but it's duplicable with Chrome 127.

Steps to reproduce:

  1. Open Google Chrome and press Control+D to create a bookmark.
  2. Press Tab or SHIFT+Tab to move around various controls in the Bookmark creation dialog and press Insert+Up (NVDA+Up) on each control, once or twice.
  3. Alternatively, you can simply press ALT+F in Google Chrome and try pressing Insert+Up on items such as History submenu, Bookmarks submenu, Make text smaller, Make text larger, Full screen, Find, More tools, etc.
  4. You may also try pressing Insert+Up on your Bookmarks in the Bookmarks submenu.

    Actual behavior:

    For most controls and items above, using Insert+Up forces NVDA to remain silent.

    Expected behavior:

    For these controls and items, NVDA should report the current line under the application cursor or spell it.

    System configuration

    NVDA installed/portable/running from source:

    Installed

    NVDA version:

    Alpha 20381, but also duplicable with alphas going back to many months. Duplicable with Alpha 33355. Also duplicable with 2020.1 to 2024.3 RC1.

    Windows version:

    Windows 10 Pro 64-Bit, version 2004, and Windows 11 24H2 (26100.1457)

    Name and version of other software in use when reproducing the issue:

    Google Chrome 83 Official to Chrome 127.

    Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Various releases over the past 3 years.

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Yes

amirsol81 commented 4 years ago

It is also worth mentioning that one can use Insert+NumPad5 (NVDA+NumPad5) as a work-around to read or spell controls or items on which Insert+Up only says Object Replacement Characte r.

DrSooom commented 4 years ago

Sounds similar to issue #10634 and it's indirectly related to issue #11177.

Adriani90 commented 4 years ago

This is a duplicate of #11177. Even if that issue title points to Firefox, the discussion goes further and touches also other places where object replacement characters are announced (i.e. Thunderbird). I am closing this one as duplicate.

Adriani90 commented 4 years ago

Ok it seems I was wrong here, this issue persists for a longer time. I thought it was related to the object replacement character. In fact, I tested with NVDA 2019.3.1 and the current line is not reported at all on these objects.

Adriani90 commented 4 years ago

This issue even occurs with NVDA 2018.2.1. @amirsol81 could you please test with an older version of Chrome? It works just well in Microsoft Edge Chromium or Firefox. So this seem really Chrome specific. cc: @ObjectInSpace

Adriani90 commented 4 years ago

Ah and if you don't mind, could you please change the title and the description saying that NVDA does not report the current line? It can be confusing for testers or developers as it is now, since the behavior changed in last alpha. Thanks.

ObjectInSpace commented 4 years ago

I can confirm that the current line is not read in Google Chrome for NVDA 2020.1 in Chrome 85, but it reads correctly for Chrome 83. So I think this issue you are now reporting is unrelated to the original one. In any case, can you confirm that this does not occur in Chrome 83.0.4103.106? I'll file this Chrome-side. Thanks much!

amirsol81 commented 4 years ago

@ObjectInSpace You are right. However, since I heard "Object Replacement Character" instead of the text of the actual control, I thought it's related to the one frequently discussed here. This happens with NVDA Official release and Chrome 83.

amirsol81 commented 4 years ago

@Adriani90 I updated the issue title and description. It's worth mentioning that I'm running Google Chrome version 83.0.4103.116 and don't have access to older releases/Chrome betas for testing purposes.

ObjectInSpace commented 4 years ago

It doesn't occur in M84 either so this is almost certainly a Chrome regression. Filed https://crbug.com/1098528 to make sure it gets taken care of.

ObjectInSpace commented 4 years ago

To be clear, the bug I filed is about NVDA+up being silent. I haven't looked into the object-replacement-character bug this was duped against yet as it seems to be an issue being worked on in NVDA alpha. LMK if I got that wrong.

amirsol81 commented 4 years ago

To be clear, the bug I filed is about NVDA+up being silent. I haven't looked into the object-replacement-character bug this was duped against yet as it seems to be an issue being worked on in NVDA alpha. LMK if I got that wrong.

@ObjectInSpace You are right. That's why I updated the bug title and description. I also added Chrome 83 to the title as I don't have other Chrome releases, old or beta.

Adriani90 commented 4 years ago

@ObjectInSpace it seems the Chrome bug is fixed. In which Chrome version will it be visible? I am on Canari 86 ut the issue is still reproducible there.

amirsol81 commented 4 years ago

It's still fully reproduceable with Google Chrome 84, the official release.

On 7/18/20, Adriani90 notifications@github.com wrote:

@ObjectInSpace it seems the Chrome bug is fixed. In which Chrome version will it be visible? I am on Canari 86 ut the issue is still reproducible there.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/11285#issuecomment-660317462

ObjectInSpace commented 4 years ago

Thanks for the pointer! Looks like this was only partially fixed. In M84 and above, you should be able to read the currently focused menu item or submenu item by line. What is not currently working are items in history or bookmarks or the tab switcher. It's not clear to me if this ever worked, however. I tested versions of Chrome that were significantly earlier than M83 and some of them read nothing at all. Updated the crbug to reflect the current status.

amirsol81 commented 4 years ago

This is still duplicable with Google Chrome version 85.0.4183.83 and latest NVDA alpha in the History/Bookmarks/Tab switcher areas.

amirsol81 commented 3 years ago

With Chrome 89 and the latest NVDA Alpha, this just affects items in the History list. But items in the menu and Bookmarks can once again be spelled.

Adriani90 commented 3 years ago

This issue is not reproducible anymore with NVDA alpha-23579,07f7bf1c and Chrome 92 under windows 10 pro 21 H1 Closing as works for me.

amirsol81 commented 1 month ago

@Adriani90 @Qchristensen @seanbudd Please reopen this as the issue is perfectly duplicable with recent releases of Chrome and all recent releases of NVDA. In fact, it hasn't been really fixed according to my experience, so I'm wondering why this has been closed. NVDA still fails to report most Chrome controls with NVDA+Up, and the same is true about spelling them with NVDA+Up pressed twice.

amirsol81 commented 1 month ago

@seanbudd @Adriani90 @Qchristensen I'm tagging you as this issue hasn't been triaged yet. It affects Chrome V127 and the latest NVDA alphas/beta/official release.

DrSooom commented 1 month ago

The latest stable version of NVDA currently is 2024.2 and the latest Beta version 2024.3 Beta 6.

seanbudd commented 1 month ago

@amirsol81 - can you please update the issue to reflect the current state of the issue

Qchristensen commented 1 month ago

I can replicate @amirsol81's original scenario with the bookmark popup dialog. Note that this is a browser dialog and nothing on a web page itself.

NVDA 2024.3 RC1 Windows 11 (64-bit) Version: 23H2, Build: 22631.3958 Chrome Version: 127.0.6533.100

Note that a workaround is to press NVDA+tab which does correctly read the control with focus.

amirsol81 commented 1 month ago

@seanbudd Additionally, NVDA+Up fails to read, or spell, menu items as we press ALT to open Chrome's menus. For instance, the list of bookmarks we've already generated can't be read or spelled via NVDA+Up though NVDA+TAB reads them. This is with Chrome 127.

seanbudd commented 1 month ago

@amirsol81 - thank you for the information as a comment, but can you please update the original issue description with the latest information.

amirsol81 commented 1 month ago

@seanbudd Sure, I just updated the issue description.

seanbudd commented 1 month ago

Thanks @amirsol81