nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.07k stars 624 forks source link

Excel - Listing the comments in the current sheet fails #11366

Open CyrilleB79 opened 4 years ago

CyrilleB79 commented 4 years ago

Steps to reproduce:

Actual behavior:

The error beep is heard and nothing is found in the comment's list. The following error is found in the log:

Input: kb(desktop):rightArrow
ERROR - RPC process 6636 (EXCEL.EXE) (11:21:26.916) - Dummy-7635 (13692):
Thread 356, build\x86\remote\excel.cpp, nvdaInProcUtils_excel_getCellInfos::<lambda_252607b36749a934dcf7252ca0219d42>::operator (), 478:
application.range failed. Code -2146827284, rangeAddress [Classeur1]Feuil1!$A$2,$A$4

IO - speech.speak (11:21:26.936) - MainThread (11308):
Speaking ['Commentaires', 'bouton radio', 'coché', 'Alt+o']

Note: this error does not occur if the comments are on contiguous cells.

Expected behavior:

No error and the both comments are listed.

System configuration

NVDA installed/portable/running from source:

Installed and portable

NVDA version:

NVDA 2020.2beta2

Windows version:

Windows 10 1809

Name and version of other software in use when reproducing the issue:

Excel 2016

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes: 2019.1.1: the issue is still present. 2019.1: All is working well.

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Yes

Additional notes:

I have not not been able to find which commit has caused this regression since my environment does not seem to allow me to runn NVDA from source from this time. Anyway, it semms that the following commit is a good candidate for this regression: commit e194b8986efc02a9d52f405307813fead21cd6f6 Author: Michael Curran michaelDCurran@users.noreply.github.com Address crash in Excel 2007 (#9456)

If this first commit is not responsible for the regression, here is another commit that may interfer: commit 0df2a494237d0364c1fa1fd51c95fdd3c93b4170 Author: Takuya Nishimoto nishimotz@gmail.com Excel cell range text should be translated. #9470 (#9471)

@michaelDCurran may you have a look since you are the author of e194b8986efc02a9d52f405307813fead21cd6f6? Thanks.

CyrilleB79 commented 3 years ago

@michaelDCurran, as the author of e194b89, may you have a look? What do you think? Anyway, the regression is between 2019.1 and 2019.1.1.

Also @feerrenrut may you at least label this issue adequately so that it is visible?

Thanks.

Adriani90 commented 2 months ago

@CyrilleB79 I cannot reproduce this anymore in NVDA 2024.2 and Office 365, can you test in Office 2016? Is this still an issue?

CyrilleB79 commented 2 months ago

Yes, it is still an issue (Microsoft® Excel® 2016 MSO (Version 2405 Build 16.0.17628.20006) 32 bits). I am quite surprised that you do not get the same result with Excel 365. Could you double check?

Strangely, just after restart, I have had no error when going on the "Note" tab; but selecting another tab and turning on the "Notes" tab makes the error appear again.