search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.09k stars 630 forks source link

NVDA reports the status of the flight mode twice in the Explorer #11849

Open cary-rowen opened 3 years ago

cary-rowen commented 3 years ago

Steps to reproduce:

I have to say that only a few laptop have a key to switch the flight mode switch. My laptop model is Dell Latitude 7490, which happens to have this feature. Press Win + M to go to the desktop, then press FN + PrintScreen.

Actual behavior:

Report "Enable airplane mode"("Disable airplane mode") twice in a row. I suspect that the cause of this problem is the same as 9466.

Expected behavior:

Report "Enable Airplane Mode"("Disable airplane mode") only once

System configuration

NVDA installed/portable/running from source:

Installed and portable

NVDA version:

2020.3 And Alpha 21386

Windows version:

Windows version: Windows 10 20H2 (64-bit) build 19042.630

Name and version of other software in use when reproducing the issue:

none

Other information about your system:

none

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

NVDA2020.2; NVDA2020.1Have the same problem

If addons are disabled, is your problem still occuring?

yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Yes.

josephsl commented 3 years ago

Hi, I suspect duplicate UIA notification event. With Windows 10 App Essentials add-on installed, can you restart NVDA with debug logging enabled, perform airplane mode toggle command, and attach the resulting log? If it is what I think it is, I’ll write a workaround in Windows 10 App Essentials add-on in December. CC @LeonardDeR

cary-rowen commented 3 years ago

Hi joseph, I have attached a debug log. I can still reproduce the problem without installing any plug-ins, so I hope NVDA can fix it. Of course, thank you very much for your efforts.

NVDA_Log.log

josephsl commented 3 years ago

Hi, at least this confirms the issue, but that’s not the data I need. Please install Windows 10 App Essentials add-on and then attach the new log. Thanks.

cary-rowen commented 3 years ago

Hi, joseph. Sorry, my log debugging level setting is inappropriate. I have re-uploaded the new log. I think this is what you need. Thanks. NVDA_Log_Debug.log

@josephsl

josephsl commented 3 years ago

Hi, yes, this is the log I was looking for, and yes, UIA notification event handler should be tweaked. I’ll get to it this weekend and come up with a workaround via Windows 10 App Essentials add-on by end of November. Thanks.

josephsl commented 3 years ago

Hi,

It turns out this might not be a UIA notification event handler issue - based on comparing logs (between my debug log and the most recent debug log attached), later airplane mode toggle announcement should be heard as speech is cut off.

What speech synthesizer are you using? Can you test it with a different speech synthesizer and see if airplane mode toggle is announced only once? If yes, this is a synthesizer problem, not really a UIA event handler issue.

Also, to help us get a better picture, can people speaking different languages and speech synthesizers (and braille displays) try replicating this problem?

Thanks.

CyrilleB79 commented 3 years ago

Issue confirmed on French Windows with all synth. Tested the following synth:

The announcement is only made in Windows Explorer, not in other apps, as for volume announcement.

josephsl commented 3 years ago

Hi, so you are saying that NVDA announces airplane mode toggle messages in French twice? This is a completely different issue than a later note about this being announced only in File Explorer – that issue was covered earlier and a PR exists (if you are implying that this should be announced everywhere, then that one has nothing to do with this one). Thanks.

Brian1Gaff commented 3 years ago

Just an aside, but even in windows 7, there are instances where things get multiple announced. Try creating a new folder in explorer in Windows 7.

I thought this kind of issue has been a bit of a problem with nvda for may years. Brian

bglists@blueyonder.co.uk Sent via blueyonder. Please address personal E-mail to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Joseph Lee" notifications@github.com To: "nvaccess/nvda" nvda@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Saturday, November 21, 2020 11:27 PM Subject: Re: [nvaccess/nvda] NVDA reports the status of the flight mode twice in the Explorer (#11849)

Hi, so you are saying that NVDA announces airplane mode toggle messages in French twice? This is a completely different issue than a later note about this being announced only in File Explorer – that issue was covered earlier and a PR exists (if you are implying that this should be announced everywhere, then that one has nothing to do with this one). Thanks.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/11849#issuecomment-731652324

CyrilleB79 commented 3 years ago

Hi, so you are saying that NVDA announces airplane mode toggle messages in French twice? This is a completely different issue than a later note about this being announced only in File Explorer – that issue was covered earlier and a PR exists (if you are implying that this should be announced everywhere, then that one has nothing to do with this one). Thanks.

Well, I do not know if I understand well your comment and if I made myself well understood.

So to summarize, in French and when I am in Explorer or on the Desktop, I have the airplane mode status reported 2 times when I press Fn+F12 (the airplane mode shortcut on my keyboard). I would have expected this status to be reported only once. HTH

josephsl commented 3 years ago

Hi, yes, that’s the issue we’re covering here. Is this reproducible when using different speech synthesizers? Thanks.

CyrilleB79 commented 3 years ago

Hi, yes, that’s the issue we’re covering here. Is this reproducible when using different speech synthesizers? Thanks.

Yes, as written in my previous message, it is reproducible with all 3 tested synthesizers: Windows OneCore, eSpeak and IBMTTS.

josephsl commented 3 years ago

Hi, got it. @LeonardDer, any thoughts? Thanks.

From: Cyrille Bougot notifications@github.com Sent: Sunday, November 22, 2020 3:12 PM To: nvaccess/nvda nvda@noreply.github.com Cc: Joseph Lee joseph.lee22590@gmail.com; Mention mention@noreply.github.com Subject: Re: [nvaccess/nvda] NVDA reports the status of the flight mode twice in the Explorer (#11849)

Hi, yes, that’s the issue we’re covering here. Is this reproducible when using different speech synthesizers? Thanks.

Yes, as written in my previous message, it is reproducible with all 3 tested synthesizers: Windows OneCore, eSpeak and IBMTTS.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/11849#issuecomment-731863340 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4AXEFZ752JECOW2BNYMHTSRGLFVANCNFSM4T5376LQ .

cary-rowen commented 3 years ago

Hi,

It is newly discovered that although adjusting the volume in the explorer has not been reported twice, it can be found from the reading viewer that NVDA has output the same content twice. @josephsl

Adriani90 commented 1 year ago

@cary-rowen how is this now in the last Windows 10 update?

cary-rowen commented 1 year ago

Unsurprisingly, nothing changed.

Adriani90 commented 7 months ago

@cary-rowen did you report this to Microsoft already?

cary-rowen commented 7 months ago

No, I did not report it to Microsoft