nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 637 forks source link

NVDA reads radio-button "checked" twice when selected #12643

Open jorgelro opened 3 years ago

jorgelro commented 3 years ago

Steps to reproduce:

Go in this link with any NVDA version after 2020.2: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_input_type_radio

Try to select the radio buttons a couple times.

Actual behavior:

Sometimes NVDA reads "checked checked" when radio button is selected.

Expected behavior:

He should read "checked" when radio button is selected.

System configuration

NVDA installed/portable/running from source:

NVDA installed and portable on Windows 10.

NVDA version:

2020.3 to 2020.1 NVDA Portuguese (Brazilian)

Windows version:

Windows 10

Name and version of other software in use when reproducing the issue:

Google Chrome version 91.0.4472.124 64 bits

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

This behavior doesn't happen in 2020.2

If add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

feerrenrut commented 3 years ago

Hi @ozzott I can't reproduce this. Can you elaborate on the steps to reproduce?

jorgelro commented 3 years ago

Hello @feerrenrut !

This behavior doesn't happen always, seems random. You can test using this HTML in a file and opening it in a browser:

`



` I simply start selecting one by one with "enter" and then "arrow down" until says "checked checked". I'm using NVDA in Portuguese (Brazil) and there is an print. ![image](https://user-images.githubusercontent.com/44803139/125619995-446077de-ba26-4e29-aff6-412fb49faf34.png)
feerrenrut commented 3 years ago

Hi @ozzott Could you please answer the questions from my last comment:

Already answered What are you doing to select the radio button?

I simply start selecting one by one with "enter" and then "arrow down" until says "checked checked"

jorgelro commented 3 years ago

Hello @feerrenrut !

First i open the document in my browser and then i turn the NVDA on with the page on the background, after that i start the navigation pressing "arrow down", since NVDA is focused on the button already. But i noticed this issue in a project of my work and the navigation they do to test is regular, since one of the QAs has visual impairment and can't visualize. They reported this issue to the developers and i tried to replicate in my personal computer to see if it was problem of the project.

Sorry, i don't know what browse/focus mode means, i simply turn the NVDA on with "Insert + S" 2x, but if you could explain i'd be happy to answer that!

feerrenrut commented 3 years ago

I made https://codepen.io/reefturner/pen/LYyOpeJ to test. I see the "checked" message duplicated in the speech viewer, but only hear it announced once. Is this true for you also?

Speech sent to the speechviewer is instantaneously shown, speech to the synthesizer takes time to be spoken. When a synthesizer is interrupted the it immediately stops speaking the old text, and starts on the new text. In this case that happens so fast that checked isn't heard twice.

While this is wasted effort from NVDA, it is unlikely to be noticed by users. It might be caused by duplicate events coming from the browser but I haven't investigated.

By default, when changing to browse mode you hear a "boop" sound, changing to focus mode you hear a "click" sound. These can be replaced with speech via the option in NVDA settings, browse mode, "Audio indication of focus and browse modes check box". A user can manually change between browse mode and focus mode with NVDA+space

jorgelro commented 3 years ago

I can see the "checked" message duplicated too, but if i "stay" at the button i can hear it being announced twice. Otherwise i won't hear it too. Yes, it don't seem to be a big issue to the user, i just thought it would be worth to notice you.

I only knew the "forms mode", now i get it! Thank you :)

feerrenrut commented 3 years ago

I can only reproduce this very rarely. Given the low impact I won't spend more time to investigate. I haven't been able to confirm hearing "checked" spoken twice yet. I'll leave this issue open in case someone else finds a way to reproduce it more reliably.

Adriani90 commented 4 months ago

I can reproduce this as follows:

  1. Open the codepen in https://github.com/nvaccess/nvda/issues/12643#issuecomment-885481952
  2. Run NVDA in browse mode
  3. Press r or arrow keys until you land on one of the 3 radio buttons (HTML, CSS or Java script), make sure you find a radio button which is disabled
  4. Press enter to enable one of them

Actual: NVDA reports e.g. on the CSS radio button "enabled enabled" Expected: NVDA should report "enabled" only once.

cc: @SaschaCowley