configuration profiles: add an option for any created profile to disable and enable specificly only that profile, raather than checking or unchecking the box to disable or enable all of the profiles together

amirmahdifard commented 1 year ago

Is your feature request related to a problem? Please describe.

currently, in the configuration profiles dialog, we only have a check box, to disable all created profiles together: exactly like manage addons dialog, a toggel option should be added for each profile, and should be called disable profile and enable profile, as how as for addons it is disable addon and enable addon: with this case, we can disable one profile that we need to disable, raather than disabling all of them with that check box: lets say i want to disable 2 of my profiles, while the others remane enable: i can only do that with addons, i can't do it with configuration profiles: but once you add this, it will be possible to do that.

Describe the solution you'd like

i like if a toggel option (disable profile and enable profile), add to the configuration profiles for all created profiles but not for the normal configuration one only, because that is the defaulte and you shouldn't be disable that one.

Describe alternatives you've considered

currently you have an option to disable all of the created profiles together, but you don't have choice to disable some profiles and leave the others as enabled if you want to do that.

Additional context

note 1: please don't mis understand me that i'm talking about the manual activate and manual deactivate options: i know those options are exist in there, those options will let you use a profile manually, or stop using it: but this request that i'm requesting, is about disable or enable a spesifik profile, exactly like disable and enable a spesifik addon in the addon manager dialog. note 2: i don't think that adding this option to that dialog would breake the api compatability or breake the addons work, because, you are not removing anything, you are not changing something that is already exist, you are just adding a new toggel option for each profile in the configuration profiles dialog to disable or enable a profile, that shouldn't breake anything at all, because as i know, there are only compatibility risk if you are actually removing or editing the current function that is already exist and the addon developers developed their addon based on that, but not when you are adding a new function because in that case, the existing addons will still work.

amirmahdifard commented 1 year ago

@josephsl hi: can i know your appinian about this feature please and if possible to develop it in the nvda project, because i feal this option will be really helpful and useful for users in that dialog, me my self first: thanks.

josephsl commented 1 year ago

Hi,

Interesting. Remember that this feature does introduce new user interface messages, and since 2023.1 API and messages might be frozen soon, I advise delaying until 2023.2 development cycle. Whoever wants to implement this must look at both the user interface component and configuration profile triggers code to implement this suggestion properly.

By the way, you don't have to ask for my opinion only- we have people who have written and commented on code, so they can also add their thoughts.

Thanks.

amirmahdifard commented 1 year ago

@josephsl thank you: i know that i can ask others too, and i didn't expect this in 2023.1 lol: generally asking, would you ok with providing pr for this and developing it for 2023.2? thanks.

amirmahdifard commented 1 year ago

i'm really excited to see if anyone is willing to develop this!

josephsl commented 1 year ago

Hi,

I wish I could, but I'm about to enter a phase in my life where I need to reduce NVDA pull requests in favor of mentoring others to take this on.

Thanks.

amirmahdifard commented 1 year ago

ok, of corce everyone is welcome: @CyrilleB79 @leonardder @mazen428 any of you can open a pr so that this ability can be in 2023.2 on nvda? thanks

amirmahdifard commented 1 year ago

@josephsl can i do a joke with you and serius at the same time? can you creat a pull request for this as last and then enter your life fasing?

josephsl commented 1 year ago

Hi,

Yes and no. Yes if I can take attention away from graduate school classes for a while, and no because I do need to focus on graduate school classes, more so during this academic term. Besides that, I'm at a point in my NVDA contribution experience where I would like to pass on what I know to the next group of developers.

Thanks.

CyrilleB79 commented 1 year ago

@amirmahdifard or @josephsl, could you please give a real-life example where disabling one or more profile(s) individually would be useful?

amirmahdifard commented 1 year ago

i don't know so much examples, but only one for now: lets say you have a problem with one of your profile, while the others working: or just in kace, one of your profiles is somehow makes your hole nvda to not function properly, or something: i like this dialog to contane this toggel option anyway, as addon manager dialog contanes it too! please don't say this feature is not useful or something, it is at least bettar than the last tikit that i created! please develop this feature in 2023.2 if possible or something, i really thinked about this designn and before i opened this tikit, i thinked so much about before i open it and i now really like it! please! thanks.

amirmahdifard commented 1 year ago

@michaelDCurran thank you for labeling this, but if possible, please make it p3 or something, i feel that p4 is doesn't matter and won't be developed or they won't care about it that much: thank you if you do it: p3 is ok i guess.

josephsl commented 1 year ago

Hi,

It is not an easy matter to change feature priority on the spot - NV Access, contributors, and others weigh in various factors when setting feature priority. Just because this issue is given a priority level 4 does not mean it will not be worked on, nor moving this up to priority level 3 will cause someone to immediately work on a pull request for this issue.

I think what you are saying is bring consistency, which is an interesting way of putting it (I myself do keep consistency in mind). However, just because one part of NVDA uses an interesting user experience does not automatically mean everything else should be consistent - what's more important I think is the purpose of the user interface (the purpose of add-ons manager and configuration profiles dialog are fundamentally different; this is why Cyrille asked for real-life examples to demonstrate the need for the feature). There are two other issues, one subtle and one based on the example provided:

Subtle issue: you can't disable all profiles.
Issue based on the example provided: a profile is a collection of settings, so disabling the profile means not getting to the heart of the matter.

Please think very carefully about these two issues, and when you are ready to talk, do post some comments (hint: read the NVDA user guide if you need to find out why I'm saying the first issue is a subtle one).

Thanks.

CyrilleB79 commented 1 year ago

i don't know so much examples, but only one for now: lets say you have a problem with one of your profile, while the others working: or just in kace, one of your profiles is somehow makes your hole nvda to not function properly, or something: i like this dialog to contane this toggel option anyway, as addon manager dialog contanes it too! please don't say this feature is not useful or something, it is at least bettar than the last tikit that i created! please develop this feature in 2023.2 if possible or something, i really thinked about this designn and before i opened this tikit, i thinked so much about before i open it and i now really like it! please! thanks.

If you have had such a problem in a profil in the past, describing it would be a good illustation illustration to this issue. Anyway, I have understood your request.

Note that until and if this ticket is implemented, you can use the following work-around: let's say that Notepad's profile is causing issue and you want to disable it:

When in Notepad,open the profile dialog (NVDA+shift+P)
Select the "Notepad" profile in the list
Press the "Trigger" button
Select "Current application (notepad)" in the trigger list
Select "Profile (normal configuration)" in the profil list
Validate This way, you have associated default profile with the Notepad trigger.

Then, when you're done, you can reassociate the notepad profile with this trigger.

Of course, it's just a workaround and something more simple may be thought if needed.

Brian1Gaff commented 1 year ago

It is a good one as it also can be used to find out what is going on when there might be more than one triggered

It is also a great pity that we cannot also have profiles that one could tie to a web site or specific page to make it less annoying. For example, if you go to the page fro The Royal Borough of Kingston council in the uK, you will find that it constantly says things like Now showing slide x or whatever, as it is a carousel. These are graphics, and of no use to us, but the pause button is way down the page. If you could arrange that the new content speaking was off for such a page, then it would be a lot better. This is by no means a singling out of that organisation, but it seems to occur whenever a web page thinks it wants to announce something new. Brian

-- @. Sent via blueyonder.(Virgin media) Please address personal E-mail to:- @., putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "Cyrille Bougot" @.> To: "nvaccess/nvda" @.> Cc: "Subscribed" @.***> Sent: Monday, January 30, 2023 9:21 AM Subject: Re: [nvaccess/nvda] configuration profiles: add an option for any created profile to disable and enable spisifikly only that profile, raather than checking the box to disable all of the profiles together (Issue #14593)

i don't know so much examples, but only one for now: lets say you have a problem with one of your profile, while the others working: or just in kace, one of your profiles is somehow makes your hole nvda to not function properly, or something: i like this dialog to contane this toggel option anyway, as addon manager dialog contanes it too! please don't say this feature is not useful or something, it is at least bettar than the last tikit that i created! please develop this feature in 2023.2 if possible or something, i really thinked about this designn and before i opened this tikit, i thinked so much about before i open it and i now really like it! please! thanks.

If you have had such a problem in a profil in the past, describing it would be a good illustation illustration to this issue. Anyway, I have understood your request.

Note that until and if this ticket is implemented, you can use the following work-around: let's say that Notepad's profile is causing issue and you want to disable it:

When in Notepad,open the profile dialog (NVDA+shift+P)

Select the "Notepad" profile in the list

Press the "Trigger" button

Select "Current application (notepad)" in the trigger list

Select "Profile (normal configuration)" in the profil list

Validate This way, you have associated default profile with the Notepad trigger.

Then, when you're done, you can reassociate the notepad profile with this trigger.

Of course, it's just a workaround and something more simple may be thought if needed.

-- Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/14593#issuecomment-1408248176 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

amirmahdifard commented 1 year ago

@CyrilleB79 ok, i can try too, but please stil develop this feature, i like to see it: thank you!

amirmahdifard commented 1 year ago

@josephsl bro, please don't mis understand me: i didn't say just because addon manager dialog have this toggel option, i want to have it in here too: of corce i had other reezen to say that too: whel, profiles are also like addons, they have the ability to be disabled and be enabled, like addons do: and anyway, if we have a check box to disable all of the profiles together, wy also not an option to disable each of them that we want like addons, hopefully this can fix your mis understandation where you said i want this just because addons manager dialog have this option.

josephsl commented 1 year ago

Hi,

The checkbox does not disable profiles themselves- it disables profile triggers, which are actions causing profiles to come to life in a specific situation such as when using specific aps and/or doing say all. I can see why disabling profiles themselves might be suggested, but this requires careful thinking.

The reason for the "thumbs down" on the earlier post is to let you know that the request to Cyrille may come across as order/command/pressure in some ways (I don't see it that way but some people might). And please do not put "LOL (laugh out loud) at the ends of comments because it can come across as though you are not serious when I can tell otherwise. Depending on people's thoughts, it can result in a range of responses from working on the pull request to closing this issue outright with no pull request (a major factor in getting an issue accepted and worked on is communication flow between the poster and others, and saying LOL could mean the poster is more interested in seeing something more than thinking about feedback; please take GitHub issue creation and feedback seriously).

Hope this helps.

Thanks.

amirmahdifard commented 1 year ago

@josephsl i'm sorry, i didn't mean to cause that problem if i say lol: i will edit my comments and remove them from my coments: hope this helps: and hope i get this feature in some version of nvda: hopefully, wich i'm hopeful about it.

amirmahdifard commented 1 year ago

and also, i don't command people to develop something, i am just requesting and saying please because i'm excited to see this feature but i am not a developer so i cannot develop it my self: thanks.

amirmahdifard commented 1 year ago

hi everyone guys, i don't want to be annoying or something, i'm just excited: nvda 2023.1 is already out, so, can you please one of you developers, bring this feature in nvda 2023.2 or something if possible? because this issue will not break api compatability: i'm excited, after this, there will be a first request from me that NVAccess has acsepted: i would be really happy: can you please do that if possible for you? thanks so much! @josephsl @michaelDCurran @CyrilleB79 @seanbudd @jcsteh @leonardder

Adriani90 commented 1 year ago

Ok maybe this discussion can go into a constructive direction. I found #12877 which basically describes the way you can assign a gesture to every profile to enable or disable the trigger on that profile. @amirmahdifard in my opinion having that feature working in NVDA first is more important than having the checkboxes in the profile dialog. In fact, that feature is already integrated but it doesn't work as expected. it would be more efficient to enable and disable profile triggers with a keyboard gesture rather than looking for a checkbox. So I think #12877 might have to be fixed first before thinking about this.

On a separate note, please let the developers do their work, there are a lot of features and requests here and it is not that easy to cope with all of them. At some point your issue will be prioritized accordingly when there is enough capacity.

amirmahdifard commented 1 year ago

@Adriani90 ok, but it doesn't have to be check box, it can also be a toggel button.