search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 637 forks source link

Translation via Crowdin - Many unmodified strings need to be re-translated #15934

Closed CyrilleB79 closed 11 months ago

CyrilleB79 commented 11 months ago

Testing Crowdin translation (French) via poedit.

Steps to reproduce:

Compare translation via Crowdin and translation via manual merge of the .pot file of NVDA 2024.1. See #15933 for more details.

Actual behavior:

Read the status bar in poedit and compare:

Expected behavior:

Same number of strings to translate.

More specifically, the following strings should not have changed:

NVDA logs, crash dumps and other attachments:

N/A

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2024.1

Windows version:

Windows 10 22H2 (AMD64) build 19045.3693

Name and version of other software in use when reproducing the issue:

Poedit, Version 3.4.1 (6867)

Other information about your system:

N/A

Other questions

CyrilleB79 commented 11 months ago

Cc @michaelDCurran

CyrilleB79 commented 11 months ago

Here is an example with two similar strings, the second has been dropped, the first not.

Original file from NVDA 2023.3

Actually last file taken from SVN.

#. Translators: The color between  red and orange (HSV hue 15 degrees)
msgctxt "color hue"
msgid "red-orange"
msgstr "rouge-orange"

#. Translators: The color orange (HSV hue 30 degrees)
msgctxt "color hue"
msgid "orange"
msgstr "orange"

Crowdin file for NVDA 2024.1

#. Translators: The color between  red and orange (HSV hue 15 degrees)
#: colors.py:190
msgctxt "color hue"
msgid "red-orange"
msgstr "rouge-orange"

#. Translators: The color orange (HSV hue 30 degrees)
#: colors.py:192
msgctxt "color hue"
msgid "orange"
msgstr ""

NVDA 2023.3 .po file + NVDA 2024.1 .pot merge

Actually I have taken:

#. Translators: The color between  red and orange (HSV hue 15 degrees)
#: colors.py:190
msgctxt "color hue"
msgid "red-orange"
msgstr "rouge-orange"

#. Translators: The color orange (HSV hue 30 degrees)
#: colors.py:192
msgctxt "color hue"
msgid "orange"
msgstr "orange"
CyrilleB79 commented 11 months ago

I did not check all the strings but maybe it's because the source and the translation are the same.

That would explain why only "orange" is missing in the colors: it's the only color that has the same name in French as in English.

michaelDCurran commented 11 months ago

If it did loose many strings I think I can undo the import if necessary.

Message ID: @.***>

zstanecic commented 11 months ago

Hi,

Undo the import then also for polish and Croatian.

I need to do some corrections.

From: Michael Curran @.> Sent: Monday, December 18, 2023 3:12 PM To: nvaccess/nvda @.> Cc: Subscribed @.***> Subject: Re: [nvaccess/nvda] Translation via Crowdin - Many unmodified strings need to be re-translated (Issue #15934)

If it did loose many strings I think I can undo the import if necessary.

Message ID: @. <mailto:@.> >

— Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/15934#issuecomment-1860607127 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE5CWB74EB4OHKUTHZLYKBFLLAVCNFSM6AAAAABAZH4MNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQGYYDOMJSG4 . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ACVCDE6RRPY3MKHFYD74FDLYKBFLLA5CNFSM6AAAAABAZH4MNWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTO42OJO.gif Message ID: @. @.> >

-- Ta wiadomość e-mail została sprawdzona pod kątem wirusów przez oprogramowanie antywirusowe Avast. www.avast.com

CyrilleB79 commented 11 months ago

If it did loose many strings I think I can undo the import if necessary. Message ID: @.***>

What do you mean?

For now there is no translation work in French translation, so you can undo what you want. Cc @MichelSuch, @CoBC.

CyrilleB79 commented 11 months ago

Additional note: The issue is probably general; does not impact only French.

zstanecic commented 11 months ago

Yes, issue impacts croatian and polish, too.

From: Cyrille Bougot @.> Sent: Monday, December 18, 2023 3:53 PM To: nvaccess/nvda @.> Cc: Zvonimir Stanečić @.>; Comment @.> Subject: Re: [nvaccess/nvda] Translation via Crowdin - Many unmodified strings need to be re-translated (Issue #15934)

Additional note: The issue is probably general; does not impact only French.

— Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/15934#issuecomment-1860707252 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE6NJKFZYMD7JTRHXTTYKBKD3AVCNFSM6AAAAABAZH4MNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQG4YDOMRVGI . You are receiving this because you commented. https://github.com/notifications/beacon/ACVCDE4CWKKZC5CFL3WE4HDYKBKD3A5CNFSM6AAAAABAZH4MNWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTO5AR3I.gif Message ID: @. @.> >

-- Ta wiadomość e-mail została sprawdzona pod kątem wirusów przez oprogramowanie antywirusowe Avast. www.avast.com

michaelDCurran commented 11 months ago

But can you confirm that the translated strings like "orange" are now there?

Message ID: @.***>

ruifontes commented 11 months ago

Michael, in portuguese "orange" was not affected since the translation is not equal. If you need to undo all languages that is not a problem to me, since I translated downloading the .PO file, translating it and uploaded to the system. The advantages are a better use of our translation database and possibility of approval of the translations in the upload process.

Adriani90 commented 11 months ago

This could happen probably also when two people translate at the same time in the same language, maybe the approval process has not been completely done in Crowdin editor due to synchronizing problems. We need to check that before importing translations into NVDA from Crowding I guess. But I might be totally wrong and the cause comes from something different.

michaelDCurran commented 11 months ago

I think trying to fix this generally for all languages now may cause some translators to loose work, so I think it is better just to let translators handle this as they best see fit. In many cases they can just upload a PO file with these translations in place, remembering to turn on the allow translation same as source option. I have manually fixed this for French however, which was the original reason for this issue I believe. I / the community can work with any other individual translators with this issue in future.

CyrilleB79 commented 11 months ago

Just confirming here that for French, the new import contains the identical translations such as "orange". Thanks.