nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.06k stars 625 forks source link

Braille: Add support for the HIMS Braille display Braille Emotion #16842

Open Nael-Sayegh opened 1 month ago

Nael-Sayegh commented 1 month ago

Is your feature request related to a problem? Please describe.

With the new HIMS Braille display "Braille Emotion," quite a few keys are not recognized or many keyboard shortcuts are not defined.

Describe the solution you'd like

Add keyboard shortcuts to this display, fully support it with these specific keys, and accept the simultaneous pressing of certain keys.

Describe alternatives you've considered

None

Additional context

LeonarddeR commented 1 month ago

cc @EdKweon

EdKweon commented 1 month ago

@Nael-Sayegh Could you please specify exactly which keys are not being recognized? Additionally, it would be helpful if you could separate your feedback for HID and Serial. Please note that while single keys have been defined, shortcut combination keys have not been defined separately. It seems that this is an issue that needs to be discussed and added according to the specific requirements of NVDA users. If you have any particular direction in mind, please let us know. Thank you.

Nael-Sayegh commented 3 weeks ago

@EdKweon Hello, I didn't quite understand your message. What do you mean by HID and serial?

Also, I don't know if you are using this Braille display, but how can I indicate the buttons to define since they don't have names?

And I didn't understand the end of your message.

EdKweon commented 3 weeks ago

@Nael-Sayegh I have a Braille eMotion.

Braille eMotion can be connected to NVDA using three methods: Braille HID, Serial, and Bluetooth. When you first entered the Connectivity(ScreenReader) app to connect to NVDA, did you select the USB connection?

Quite a few keys are not recognize I want to know what keys are not recognized. Give me a example that not works.

Thanks.

Nael-Sayegh commented 3 weeks ago

@EdKweon When I connected the braille display, I connected it via Bluetooth. The keys not recognized on the display are W, B, and C. The Home button on the front of the display has an assigned function but does not have a name to be remapped. The F3 and F4 keys on the display do not work with other control keys like F1 or F8. The arrow keys on the right and left sides of the display cannot be remapped to simulate the down arrow and up arrow, for example.

EdKweon commented 3 weeks ago

@Nael-Sayegh I can't understand what is W, B and C. Does it mean dot keys? (ex: 'W' is dot 2 - 4 - 5 -6) As far as I know, the braille eMotion device only has F1, F2, F3, and F4 keys. Are you perhaps referring to the Cursor Keys when you mention Arrow Keys?

Nael-Sayegh commented 2 weeks ago

@EdKweon I'm talking about the three buttons at the top left of the device, where 'w', 'b', and 'C' are written in Braille on each of them, in that order."

If you require a more technical approach, especially if this is for instructions or documentation, you could say:

"I am referring to the three buttons located at the top left corner of the device. Each button has a Braille label: 'w' on the first button, 'b' on the second, and 'C' on the third, in that specific order.

EdKweon commented 2 weeks ago

@Nael-Sayegh Thanks. You mean Wifi, Blutooth, Connectivity buttons.

Let me confirm my understanding. Are you saying that currently, the cursor key and home key on the display are not mapped in the Bluetooth connection?(Maybe other keys are more)

Secondly, what actions do you want the three buttons at the top left to perform in NVDA? As far as I know, these keys do not have any assigned functions in control keys.

Nael-Sayegh commented 2 weeks ago

@EdKweon Yes, those are exactly the keys I'm talking about. I didn't necessarily think about giving them a default function but at least allowing them to be remapped to suit individual needs. Personally, I was planning to assign them functions like alt+tab, windows+tab, and application.

Nael-Sayegh commented 2 weeks ago
  • Par exemple, la touche Accueil sur l'écran ne fonctionne pas -> f1 ~ f8 (touches de contrôle) ne fonctionnent pas.

@EdKweon I didn't understand your request.

EdKweon commented 2 weeks ago

@Nael-Sayegh I was literally asking if the home key or cursor keys on the display are not working in Bluetooth connection.

Nael-Sayegh commented 2 weeks ago

@EdKweon The cursors work correctly in Bluetooth. What do you mean by the home button? If it's the one between points 1 and 4, when I press it, it shows me something like "clipboard content," but I've never managed to understand what it does. If you're talking about the middle button on the front, it works by having the F1 function.

EdKweon commented 2 weeks ago

@Nael-Sayegh I am sorry, but the three buttons on the top left of the Braille eMotion will not be supported in the NVDA screen reader key dictionary. This is also true for USB connections. Secondly, is the home key on the display performing the F1 function when connected via Bluetooth? As far as I remember, it should perform the ESC function. What function does the F2 key on display perform?