search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 637 forks source link

Visual Higlight not showing correctly when navigating between paragraphs with P or same style text command #16891

Open Qchristensen opened 3 months ago

Qchristensen commented 3 months ago

Steps to reproduce:

Initially reported by user Brian by email.

  1. Ensure NVDA's Visual Highlight feature is active.
  2. Open a web page - user suggestion was the In-Process I covered navigating by paragraph: https://www.nvaccess.org/post/in-process-19th-july-2024/
  3. Press P to move forward by paragraph
  4. Press shift+p to move back by paragraph
  5. If a gesture assigned to "Moves between same style text", press that gesture (see https://www.nvaccess.org/post/in-process-20th-june-2024/#gestures for details)

Actual behavior:

NVDA moves as expected, but visual highlight either doesn't appear or jumps to a different part of the screen.. What appears to be happening is that the screen scrolls to ensure the new paragraph is fully visible, but visual highlight jumps to where the text was before the screen scrolled.

Expected behavior:

Scroll the screen and THEN show the focus highlight for the updated text position.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

NVDA version:

NVDA 2024.3 Beta 4

Windows version:

Windows 11 (64-bit) Version: 23H2, Build: 22631.3880

Name and version of other software in use when reproducing the issue:

Chrome Version: 126.0.6478.128 Firefox version: 128.0

(Reproduced with both)

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Adriani90 commented 3 months ago

cc: @mltony, @LeonarddeR

mltony commented 3 months ago

I am not very familiar with how visual highlight works - nor can I see well enough to observe this myself. One thing I'd like to mention is that For both P and same style paragraph commands, I am just returning a TextInfo object - the rest is processed by existing QuickNav logic. So maybe the issue is that TextInfos returned by P or same style commands are peculiar in some way. Wondering if visual highlighting works reliably for other quickNav commands, especially the ones that take you to a non-focusable objects, like L, N or Q?

Qchristensen commented 2 months ago

I just noticed #10672 which is a similar issue - visual highlight not moving correctly, but specifically mentioned scrolling pages with the mouse.

I'm cross linking both for the conceptual link, although I'll leave both open as the technical solution may be different for each.