nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.12k stars 638 forks source link

Update configobj #17371

Closed SaschaCowley closed 2 weeks ago

SaschaCowley commented 2 weeks ago

Link to issue number:

Closes #17328

Summary of the issue:

Configobj has received a number of updates since we last updated, most significantly dropping Python 2 support and fixing security issues.

Description of user facing changes

None

Description of development approach

Updated configobj in requirements.txt.

Testing strategy:

Unit and system tests.

Known issues with pull request:

None.

Code Review Checklist:

@coderabbitai summary

SaschaCowley commented 2 weeks ago

@seanbudd we're currently on 5.1, and it seems that downgrading to 5.0.9 breaks a bunch of unit tests.

Test output ``` ERROR [0.000s]: test_argsMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_argsMissingIsError) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 112, in test_argsMissingIsError featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 167, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_behaviorOfDefaultMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_behaviorOfDefaultMissingIsError) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 98, in test_behaviorOfDefaultMissingIsError featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 192, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_behaviorOfDefaultTypeMustBeStr (tests.unit.test_config.Config_FeatureFlag_specTransform.test_behaviorOfDefaultTypeMustBeStr) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 118, in test_behaviorOfDefaultTypeMustBeStr featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 198, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_optionsEnumMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_optionsEnumMissingIsError) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 105, in test_optionsEnumMissingIsError featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 167, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_optionsEnumMustBeKnown (tests.unit.test_config.Config_FeatureFlag_specTransform.test_optionsEnumMustBeKnown) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 135, in test_optionsEnumMustBeKnown featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 182, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_paramDefaultIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_paramDefaultIsError) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 89, in test_paramDefaultIsError featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 160, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ====================================================================== ERROR [0.000s]: test_tooManyParamsIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_tooManyParamsIsError) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\projects\nvda\tests\unit\test_config.py", line 126, in test_tooManyParamsIsError featureFlag._transformSpec_AddFeatureFlagDefault( File "D:\projects\nvda\source\config\featureFlag.py", line 217, in _transformSpec_AddFeatureFlagDefault raise VdtParamError( ^^^^^^^^^^^^^^ TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg' ---------------------------------------------------------------------- Ran 757 tests in 16.563s FAILED (errors=7) ```