search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.08k stars 626 forks source link

NVDA Should report alignment in LibreOffice Writer #2204

Closed nvaccessAuto closed 10 months ago

nvaccessAuto commented 12 years ago

Reported by ateu on 2012-03-31 17:24 Hello,

This is the only one information which is not reported in the IBM's Office Suite. Please furgive me if htis is a problem with IBM Lothus Symphony.

Regardes Blocking #4003

nvaccessAuto commented 12 years ago

Comment 1 by ateu on 2012-08-20 22:31 Please say me whether I should open another ticket about alignment in IAccessible. If so, can I close this one?

Thanks

nvaccessAuto commented 12 years ago

Comment 2 by jteh on 2012-08-20 23:38 What do you mean by alignment in IAccessible? What other application do you want alignment reported in?

Symphony actually doesn't follow the IAccessible2 standard for formatting info, so we have to address it separately.

nvaccessAuto commented 12 years ago

Comment 3 by ateu (in reply to comment 2) on 2012-08-21 00:25 Replying to jteh:

What do you mean by alignment in IAccessible? What other application do you want alignment reported in?

Firefox and thunderbird. In Internet Explorer, this information is provided. So to be logical, firefox should also provide.

Symphony actually doesn't follow the IAccessible2 standard for formatting info, so we have to address it separately.

Ok.

nvaccessAuto commented 12 years ago

Comment 4 by jteh (in reply to comment 3) on 2012-08-22 06:29 See #2612 regarding alignment for standard IAccessible2.

nvaccessAuto commented 10 years ago

Comment 5 by ateu on 2013-12-25 14:48 Hi

Currently, this is important, since OpenOffice and LibreOffice will be updated with this APIs

nvaccessAuto commented 10 years ago

Comment 7 by jteh on 2014-03-21 00:03 I discovered Symphony/OOo/LO expose this using the ParaAdjust text attribute, which is non-standard. (This isn't surprising, since all of their attributes are non-standard.) It seems that center is ParaAdjust:3. I'm not sure what the other values are yet.

ehollig commented 7 years ago

@jcsteh, is this issue specific to Symphony or does it apply to OO/LO as well? If it is specific to Symphony then I suspect that this issue can be closed.

jcsteh commented 7 years ago

Applies to LO as well.

Marlin86 commented 5 years ago

Unfortunately this problem persists. I think LibreOffice and OpenOffice are so important programs, as they are used by millions of people, public schools, Universities and other. Therefore, they should receive more attention.

LeonarddeR commented 5 years ago

I'm afraid it's exactly the other way around. As these applications are used quite often, it would be good if the projects themselves would devote more attention to accessibility and to following standards.

Adriani90 commented 5 years ago

I guess if Libre Office or Open Office do not expose this information, NVDA cannot do much to improve it. However, since they are also open source projects, I think people facing such issues could create issues on Github or on their issue trackers. I mean especially people who are using NVDA. I wonder if there are some issues reported by NVDA users on Libre Office or Open Office issue trackers? Here is a wiki with all channels where you can report issues in Libre office: https://wiki.documentfoundation.org/QA/BugReport

And here is how to submit issues in Open Office: https://www.openoffice.org/qa/issue_handling/pre_submission.html

Regarding Open office, it seems the development is not very active anymore. There is like a new version in one or two years.

surfer0627 commented 5 years ago

@Adriani90 commented

I guess if Libre Office or Open Office do not expose this information, NVDA cannot do much to improve it.

Yes. In the past, developer Jteh used to point out:

Symphony actually doesn't follow the IAccessible2 standard for formatting info, .....

And tdf 91739 – nvda can not read documents from top to bottom. - is One of issues reported on LibreOffice issue tracker.

My question is that is it possible for NVDA developers to submit changes to the LibreOffice Git repository to fix IAccessible2 standard issue?

Related links:

joanmarie commented 4 years ago

I came across this while trying to figure out some history about when text alignment started being treated as an object attribute in IA2. (It's a text attribute in ATK so we have API misalignment which makes implementors sad. But I digress.)

In LibreOffice Writer, for ATK, text alignment is correctly exposed as a text attribute. See https://cgit.freedesktop.org/libreoffice/core/tree/vcl/unx/gtk3/a11y/gtk3atktextattributes.cxx. In particular, this line: "ParaAdjust", // TEXT_ATTRIBUTE_JUSTIFICATION

To see if that was happening in Windows as well, I installed LibreOffice, centered a paragraph, and used NVDA's Python Console to get that paragraph's text attributes. Here's what I got:

(0, 11, 'Version:1;:;CharBackColor:#00FFFFFF;CharColor:#00000000;CharContoured:0;CharEmphasis:0;CharEscapement:0;CharFontName:Liberation Serif;CharHeight:12;CharPosture:0;CharShadowed:0;CharStrikeout:0;CharUnderline:0;CharUnderlineColor:#00000000;CharWeight:100;ParaAdjust:3;ParaBottomMargin:0;ParaFirstLineIndent:0;ParaLeftMargin:0;ParaLineSpacing:Mode=0,Height=100,;ParaRightMargin:0;ParaTabStops:Position=48,TabAlign=0,DecimalChar= ,FillChar= ,;')

Bit of a blob, but note that ParaAdjust:3 is there. That seems to be your alignment. It's not exposed as an object attribute, but it is obtainable as a text attribute.

If NVDA is getting all the other text attributes in order to report them (e.g. in response to NVDA+f), it could arguably check for alignment as part of it. Just like I'm probably going to have to modify Orca to check the object attributes on top of the text attributes, because Firefox stopped treating text alignment as a text attribute.

jcsteh commented 4 years ago

I came across this while trying to figure out some history about when text alignment started being treated as an object attribute in IA2.

As far as I know, it was always an object attribute in IA2. The justification was probably that it applies to the whole paragraph, not an individual span of text.

Bit of a blob, but note that ParaAdjust:3 is there.

Indeed, as I noted in https://github.com/nvaccess/nvda/issues/2204#issuecomment-155296609.

If NVDA is getting all the other text attributes in order to report them (e.g. in response to NVDA+f), it could arguably check for alignment as part of it.

Oh, sure it could. NVDA already has a bunch of code to deal with LO's non-standard attribute names. Someone just has to implement it.

Just like I'm probably going to have to modify Orca to check the object attributes on top of the text attributes, because Firefox stopped treating text alignment as a text attribute.

Off-topic, but you should file a Mozilla bug about that. if the documented ATK standard is to expose it as a text attribute, servers should follow the standard. :)

michaelweghorn commented 10 months ago

Comment 7 by jteh on 2014-03-21 00:03 I discovered Symphony/OOo/LO expose this using the ParaAdjust text attribute, which is non-standard. (This isn't surprising, since all of their attributes are non-standard.) It seems that center is ParaAdjust:3. I'm not sure what the other values are yet.

LibreOffice 24.2 will use standard IA2 text and object attributes and with NVDA 2024.1, text alignment is reported as expected, s. https://bugs.documentfoundation.org/show_bug.cgi?id=135922 and PR https://github.com/nvaccess/nvda/pull/15649 for details.

I think this issue can therefore be closed. (And from what I can see, it's about the same issue as #6913.)

Adriani90 commented 10 months ago

Thanks for updating and for the great work on this @michaelweghorn. Very appreciated.

I am closing this issue as works for me. Please comment if you are still having this issue in LO 24.2 and we can reopen.