search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
https://www.nvaccess.org/
Other
2.11k stars 638 forks source link

navigatorObject_toFocus doesn't send a becomeNavigatorObject event #3464

Open nvaccessAuto opened 11 years ago

nvaccessAuto commented 11 years ago

Reported by dpeschel on 2013-08-24 00:54 These methods all send becomeNavigatorObject events: navigatorObject_parent navigatorObject_previous navigatorObject_next navigatorObject_firstChild

but navigatorObject_toFocus doesn't. This seems odd if you consider navigatorObject_toFocus as equivalent to some sequence of the other four actions.

(Tested using Takuya Nishimoto's FocusHighlight add-in. I removed the timer-driven redraws to see if I could speed up response time. The timer-driven redraws hide this behavior; removing them reveals it.)

LeonarddeR commented 7 years ago

Confirmed. @JCSTeh: Do you agree with a p4 here? It is probably quite easy to fix, but not very important. In the case of focus highlight, you are moving the navigator object to focus, so you already have the highlight around the focus.

jcsteh commented 7 years ago

Labelled p4 and also goodForNewDev.

Adriani90 commented 5 years ago

@leonardder this might be of interest when implementing the focus and carret highlighting PR.