search

nvaccess / nvda

NVDA, the free and open source Screen Reader for Microsoft Windows
Other
2.08k stars 626 forks source link

"Reset configuration to factory defaults" would need a confirmation dialog. #6648

Open MichelSuch opened 7 years ago

MichelSuch commented 7 years ago

When in the NVDA menu, some user sometimes incidentally press the R key (or its equivalent key in other languages) whici resets NVDA to factory defaults. Some are not able to reconfigure NVDA by themselves, and, in any case, it can take some times to get back to the wanted configuration. So, it would be nice if this reset function could have a confirmation dialog when the key is pressed.

Refer to https://github.com/nvaccess/nvda/issues/6648#issuecomment-431714383, https://github.com/nvaccess/nvda/issues/6648#issuecomment-720161834 for implementation details

LeonarddeR commented 7 years ago

NOTE that one can always go back to the saved configuration after a reset, since the reset configuration will only be saved after a quit of NVDA or an explicit save. That said, I agree a confirmation window would be helpful. I can send in a pr for this if core devs desire so.

N.B. Sent on behalf of @BabbageCom

Op 17 dec. 2016 om 09:57 heeft MichelSuch notifications@github.com het volgende geschreven:

When in the NVDA menu, some user sometimes incidentally press the R key (or its equivalent key in other languages) whici resets NVDA to factory defaults. Some are not able to reconfigure NVDA by themselves, and, in any case, it can take some times to get back to the wanted configuration. So, it would be nice if this reset function could have a confirmation dialog when the key is pressed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Brian1Gaff commented 7 years ago

If you followed the way windows system restore worked you would need to have a way back to the saved most recent config as well of course. the question is, how far down the road do you want this to go. Its a bit like the undo function in an editor, how far do you go? Brian

bglists@blueyonder.co.uk Sent via blueyonder. Please address personal email to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "MichelSuch" notifications@github.com To: "nvaccess/nvda" nvda@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Saturday, December 17, 2016 8:57 AM Subject: [nvaccess/nvda] "Reset configuration to factory defaults" would need a confirmation dialog. (#6648)

When in the NVDA menu, some user sometimes incidentally press the R key (or its equivalent key in other languages) whici resets NVDA to factory defaults. Some are not able to reconfigure NVDA by themselves, and, in any case, it can take some times to get back to the wanted configuration. So, it would be nice if this reset function could have a confirmation dialog when the key is pressed.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/6648

MichelSuch commented 7 years ago

I think a simple dialog like:

Do you really want to get back to factory settings ?

OK

Cancel

would be enough.

Just to inform unexperimented users about what they have done.

                 Michel SUCH

michel.such@free.fr Skype : michel.such Twitter : @SuchMichel

Le 17/12/2016 à 12:12, Brian1Gaff a écrit :

If you followed the way windows system restore worked you would need to have a way back to the saved most recent config as well of course. the question is, how far down the road do you want this to go. Its a bit like the undo function in an editor, how far do you go? Brian

bglists@blueyonder.co.uk Sent via blueyonder. Please address personal email to:- briang1@blueyonder.co.uk, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: "MichelSuch" notifications@github.com To: "nvaccess/nvda" nvda@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Saturday, December 17, 2016 8:57 AM Subject: [nvaccess/nvda] "Reset configuration to factory defaults" would need a confirmation dialog. (#6648)

When in the NVDA menu, some user sometimes incidentally press the R key (or its equivalent key in other languages) whici resets NVDA to factory defaults. Some are not able to reconfigure NVDA by themselves, and, in any case, it can take some times to get back to the wanted configuration. So, it would be nice if this reset function could have a confirmation dialog when the key is pressed.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/nvaccess/nvda/issues/6648

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-267757103, or mute the thread https://github.com/notifications/unsubscribe-auth/APFCjwa05_S-dqvHDlTnS0KvZLaxt1Jcks5rI8OggaJpZM4LP1nx.

jcsteh commented 7 years ago

The problem here is that sometimes, users need to use this (generally via a triple press of NVDA+control+r) to recover from a situation where they've changed configuration such that speech or braille (whichever is their primary output method) is unusable. If we force a dialog on the user in order to proceed, they may simply not be able to recover, since they can't read the dialog. As noted earlier, you can always immediately revert to the saved configuration if you do this by mistake.

feerrenrut commented 7 years ago

Perhaps we could display a dialog after the reset. Informing users of what happened and how to revert to the previously saved configuration.

derekriemer commented 7 years ago

We could restore to defaults and then show a dialog with undo and okay buttons.

On 12/18/2016 3:53 PM, James Teh wrote:

The problem here is that sometimes, users need to use this (generally via a triple press of NVDA+control+r) to recover from a situation where they've changed configuration such that speech or braille (whichever is their primary output method) is unusable. If we force a dialog on the user in order to proceed, they may simply not be able to recover, since they can't read the dialog. As noted earlier, you can always immediately revert to the saved configuration if you do this by mistake.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-267853187, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGiveytrA8_kq5JXYpZd-EJZMivUjX0ks5rJblZgaJpZM4LP1nx.

-- 

Derek Riemer

Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu Phone: (303) 906-2194

derekriemer commented 7 years ago

I read Reefs mind literally at the same time he read mine.

On 12/18/2016 7:09 PM, Reef Turner wrote:

Perhaps we could display a dialog after the reset. Informing users of what happened and how to revert to the previously saved configuration.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-267866668, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGivet_4LFdxzaezR8plCfmiKjEohk4ks5rJed1gaJpZM4LP1nx.

-- 

Derek Riemer

Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu Phone: (303) 906-2194

MichelSuch commented 7 years ago

Yes, this looks good.

                 Michel SUCH

michel.such@free.fr Skype : michel.such Twitter : @SuchMichel

Le 19/12/2016 à 03:10, derekriemer a écrit :

We could restore to defaults and then show a dialog with undo and okay buttons.

On 12/18/2016 3:53 PM, James Teh wrote:

The problem here is that sometimes, users need to use this (generally via a triple press of NVDA+control+r) to recover from a situation where they've changed configuration such that speech or braille (whichever is their primary output method) is unusable. If we force a dialog on the user in order to proceed, they may simply not be able to recover, since they can't read the dialog. As noted earlier, you can always immediately revert to the saved configuration if you do this by mistake.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-267853187, or mute the thread

https://github.com/notifications/unsubscribe-auth/AFGiveytrA8_kq5JXYpZd-EJZMivUjX0ks5rJblZgaJpZM4LP1nx.

--

Derek Riemer

  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu Phone: (303) 906-2194

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-267866732, or mute the thread https://github.com/notifications/unsubscribe-auth/APFCj43Qc_91zzh2d1nrzeWPQM9yOe2yks5rJeeegaJpZM4LP1nx.

feerrenrut commented 7 years ago

If everyone is happy with this UX then I will set this to priority 3.

MichelSuch commented 7 years ago

yes, good for me.

                 Michel SUCH

michel.such@free.fr Skype : michel.such Twitter : @SuchMichel

Le 2016-12-21 à 10:29, Reef Turner a écrit :

If everyone is happy with this UX then I will set this to priority 3.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nvaccess/nvda/issues/6648#issuecomment-268476545, or mute the thread https://github.com/notifications/unsubscribe-auth/APFCj-1pVpCtDN2MmGBO04Ioy2j5OEPBks5rKPFmgaJpZM4LP1nx.

LeonarddeR commented 7 years ago

I agree. Might dive into implementing this later this or next week. Shouldn't be that difficult.

LeonarddeR commented 7 years ago

After discussing this with @dkager, I think it is useless to add a confirmation prompt in case of triple nvda+ctrl+r. This is a hotkey which is quite difficult to press unintentionally, so people using this hotkey do know what they're doing. Furthermore, after another nvda+ctrl+r, they are back to the last saved configuration. The dialog can be shown before the reset in the case that only the menu item will make it show up.

MichelSuch commented 7 years ago

Yes, in fact the original idea was to bring up this dialog when performing reset from the NVDA menu, which may result of a non intentionnal key press.

dkager commented 7 years ago

I agree with @leonardder. The primary scenario for me is that I want to press NVDA+N, P, R but accidentally leave out the P. To restore the config through the menu, I would say memorizing NVDA+N, R, Enter (to confirm) isn't harder than if you leave out the Enter at the end. Of course the user has to know that a confirmation dialog will pop up, but that can be added to the user guide.

bhavyashah commented 7 years ago

We still have some debate with regards to the UX of this suggestion. Thoughts/inputs? @jcsteh @leonardder @dkager and other participants...

LeonarddeR commented 6 years ago

If all who were involved in the discussion agree that a confirmation dialog would be helpful in the case that this option is activated from the menu, that would help. Still, I belief that a confirmation is not necessary in case of a triple nvda+control+r.

Qchristensen commented 5 years ago

I agree with all the conversation to date, I think EITHER show a prompt after resetting (however the reset is activated) with options to undo or ok. or have the option to show a prompt only when resetting from the menu. I tend to favour the first option. I think it's unlikely you'll inadvertently reset to factory defaults using the keystroke, but you shouldn't need to do it so often than an extra prompt is that much of a hassle. It is more likely that a user might accidentally trigger the menu option. I was also thinking that putting a prompt before the reset only when triggered via the menu option could still cause problems, as you might mess up the voice and be unable to understand it, but remember how to get to the option via the menu rather than the keystroke.

Qchristensen commented 3 years ago

In looking at a couple of other settings screens not currently covered by the reset to factory defaults, I found:

Additionally, I would like to propose here, that when implementing a dialog confirmation for resetting to factory defaults, that the dialog offer checkboxes to also reset speech dictionaries, symbol pronunciation and input gestures.

Finally, a checkbox could also be included to disable all add-ons, as per #10134

LittleStar-VIP commented 2 years ago

I just press the reset configuration to factory default by accident. I really would like nvda to have a double confirmation before it really applys reset.

Adriani90 commented 5 months ago

16373 has been also closed due to the concerns already covered in this issue. I think a dialog is tricky to implement here because either speech or braille could be set in wrong language or could be broken at all so the dialog becomes unusable.

I am in favor of just displaying a dialog after settings have been reset, as proposed by Reef and Derek in https://github.com/nvaccess/nvda/issues/6648#issuecomment-267866668 and next.

Jonathans859 commented 4 weeks ago

I believe just a simple confirmation dialog would be no huge deal. It would help a lot of users who are unexperienced, and even I who uses NVDA for 2 years now nuked my configuration yesterday and had no clue how to get it back, especially because I originally only wanted to restart NVDA and couldn't revert back, and had no clue if and where backups are.

XLTechie commented 4 weeks ago

@Jonathans859 as discussed earlier, it would be a "huge" deal. Consider: a user has broken NVDA so that it doesn't speak, or isn't emitting braille. Or, it is speaking so fast, or in a foreign language, that the user can't understand it.

How can such a user respond to such a dialog, when they don't even know it is being shown?

I still believe that the best compromise is to reset automatically, but then do not automatically save the new configuration on exit.

Jonathans859 commented 4 weeks ago

@XLTechie Sorry if I'm doing something wrong with the mentioning here, I use github issues for the first time. Well but then you can say that for many other dialogs as well. I get it, but a simple yes no dialog? Hmm, I mean you have a vallied point, and I would have no problem if it would be like you said, as long as there is something which prevents your config to say bye bye...

SaschaCowley commented 4 weeks ago

I think a solution has already been discussed though: reset to factory defaults, and then explain what has happened and offer the option to go back.

XLTechie commented 4 weeks ago

@Jonathans859 You are using issues as expected for this project as far as i can tell, nothing to worry about here.

The current experience for resetting is certainly not ideal, we can agree on that point. I know too many users who have done as you did, and lost their configurations.

But I also know of some who have gotten into situations like I described, and being able to run that command "blindly" (without any feedback), has been the only way out.

I think the intent is for the key to be pressed once, which will reset to the currently saved config. If NVDA still isn't working, it is then assumed that the saved config is corrupted, and factory resetting won't hurt anything at that point.

amirsol81 commented 4 weeks ago

@XLTechie @Qchristensen I also support displaying a confirmation dialog upon pressing the key stroke or selecting the Reset configuration to factory defaults menu item. Honestly it's rather odd that such an important feature is executed without seeking user confirmation. For the sake of comparison, JAWS also offers a similar feature, but when it's activated, the following dialog gets displayed: Restore to Factory Settings This option will delete all your current settings and restart JAWS. Are you sure you want to continue? Yes No